Add structured error parsing for user_cherry_pick
Gitaly's UserCherryPick RPC will begin to return structured errors. The reason is that currently we return an error message embedded in the response and hence it looks like the RPC succeeded. This not only hides errors in the metrics and logs, Praefect will also expect transaction voting to happen correctly for successful requests. However, an error happened which sometimes causes voting to not happen at all. In this situation, Praefect will schedule unneeded replication jobs.
This change prepares for the Gitaly change by putting in place code that parses the structured error and raises the same errors as it did when parsing the response for the analagous errors.
part of: gitaly#4111 (closed)
similar to: !82626 (merged)
Changelog: changed
Merge request reports
Activity
assigned to @jcaigitlab
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@JobV
,@marin
,@allison.browne
,@ayufan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender BotReviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+10, 14 hours ahead of@jcaigitlab
)Dylan Griffith ( @DylanGriffith
) (UTC+10, 14 hours ahead of@jcaigitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerchanged milestone to %15.0
added groupgitaly typemaintenance labels
requested review from @jagood
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 21d14354expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 23 | 0 | 2 | 23 | ❗ | | Manage | 36 | 0 | 2 | 38 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 114 | 0 | 9 | 116 | ❗ | +----------------------+--------+--------+---------+-------+--------+
Setting label(s) Category:Gitaly devopscreate sectiondev based on groupgitaly.
added Category:Gitaly devopscreate sectiondev labels
added 1 commit
- 7dc4e2f9 - Add structured error parsing for user_cherry_pick
added 1 commit
- 41a94df0 - Add structured error parsing for user_cherry_pick
- Resolved by Jason Goodman
- Resolved by James Fargher
- Resolved by Jason Goodman
- Resolved by James Fargher
- Resolved by James Fargher
I had a few questions, @jcaigitlab. Back to you.
removed review request for @jagood
mentioned in issue gitlab-com/www-gitlab-com#13344 (closed)
added 658 commits
-
41a94df0...c80a87aa - 657 commits from branch
master
- ddc73cdf - Add structured error parsing for user_cherry_pick
-
41a94df0...c80a87aa - 657 commits from branch
requested review from @jagood
- Resolved by James Fargher
@jagood thanks for the review!
responded to your comments and had a question. thanks!
removed review request for @jagood
added 409 commits
-
ddc73cdf...8e9d3b33 - 408 commits from branch
master
- bee39f78 - Add structured error parsing for user_cherry_pick
-
ddc73cdf...8e9d3b33 - 408 commits from branch
- Resolved by James Fargher
@jagood should be ready for another look!
requested review from @jagood
@jagood
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @jagood
added 1259 commits
-
bee39f78...194769da - 1258 commits from branch
master
- e72aa2d8 - Add structured error parsing for user_cherry_pick
-
bee39f78...194769da - 1258 commits from branch
added 384 commits
-
e72aa2d8...7b599774 - 383 commits from branch
master
- 107cadbb - Add structured error parsing for user_cherry_pick
-
e72aa2d8...7b599774 - 383 commits from branch
added 169 commits
-
107cadbb...f0e6ecd6 - 168 commits from branch
master
- 21d14354 - Add structured error parsing for user_cherry_pick
-
107cadbb...f0e6ecd6 - 168 commits from branch
@proglottis could you take the maintainer review on this?
requested review from @proglottis
changed milestone to %15.1
added missed:15.0 label
enabled an automatic merge when the pipeline for 0cfa80e9 succeeds
mentioned in commit dde3a70e
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request gitaly!4585 (merged)
mentioned in merge request !90565 (merged)
added releasedpublished label
mentioned in merge request kubitus-project/kubitus-installer!1153 (merged)
added releasedcandidate label and removed releasedpublished label