Skip to content
Snippets Groups Projects

Add structured error parsing for user_cherry_pick

Merged John Cai requested to merge jc-structured-errors-for-cherry-pick into master
All threads resolved!

Gitaly's UserCherryPick RPC will begin to return structured errors. The reason is that currently we return an error message embedded in the response and hence it looks like the RPC succeeded. This not only hides errors in the metrics and logs, Praefect will also expect transaction voting to happen correctly for successful requests. However, an error happened which sometimes causes voting to not happen at all. In this situation, Praefect will schedule unneeded replication jobs.

This change prepares for the Gitaly change by putting in place code that parses the structured error and raises the same errors as it did when parsing the response for the analagous errors.

part of: gitaly#4111 (closed)

similar to: !82626 (merged)

Changelog: changed

Edited by John Cai

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jason Goodman
  • Jason Goodman
  • Jason Goodman
  • Jason Goodman
  • I had a few questions, @jcaigitlab. Back to you. :ping_pong:

  • Jason Goodman removed review request for @jagood

    removed review request for @jagood

  • John Cai added 658 commits

    added 658 commits

    Compare with previous version

  • John Cai requested review from @jagood

    requested review from @jagood

  • Jason Goodman removed review request for @jagood

    removed review request for @jagood

  • John Cai added 409 commits

    added 409 commits

    Compare with previous version

  • John Cai requested review from @jagood

    requested review from @jagood

  • Jason Goodman approved this merge request

    approved this merge request

  • :wave: @jagood, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Jason Goodman removed review request for @jagood

    removed review request for @jagood

  • John Cai added 1259 commits

    added 1259 commits

    Compare with previous version

  • John Cai added 384 commits

    added 384 commits

    Compare with previous version

  • John Cai added 169 commits

    added 169 commits

    Compare with previous version

  • Author Developer

    @proglottis could you take the maintainer review on this?

  • John Cai requested review from @proglottis

    requested review from @proglottis

  • 🤖 GitLab Bot 🤖 changed milestone to %15.1

    changed milestone to %15.1

  • James Fargher resolved all threads

    resolved all threads

  • James Fargher approved this merge request

    approved this merge request

  • James Fargher enabled an automatic merge when the pipeline for 0cfa80e9 succeeds

    enabled an automatic merge when the pipeline for 0cfa80e9 succeeds

  • merged

  • James Fargher mentioned in commit dde3a70e

    mentioned in commit dde3a70e

  • added workflowstaging label and removed workflowcanary label

  • Toon Claes mentioned in merge request gitaly!4585 (merged)

    mentioned in merge request gitaly!4585 (merged)

  • John Cai mentioned in merge request !90565 (merged)

    mentioned in merge request !90565 (merged)

  • Please register or sign in to reply
    Loading