Skip to content
Snippets Groups Projects

Add structured error parsing for user_cherry_pick

Merged Add structured error parsing for user_cherry_pick
jc-structured-errors-for-cherry-pick into master
Merged John Cai requested to merge jc-structured-errors-for-cherry-pick into master
  1. May 20, 2022
    • John Cai's avatar
      Add structured error parsing for user_cherry_pick · 21d14354
      John Cai authored 
      Gitaly's UserCherryPick RPC will begin to return structured errors. The
reason is that currently we return an error message embedded in the
response and hence it looks like the RPC succeeded. This not only hides
errors in the metrics and logs, Praefect will also expect transaction
voting to happen correctly for successful requests. However, an error
happened which sometimes causes voting to not happen at all. In this
situation, Praefect will schedule unneeded replication jobs.

This change prepares for the Gitaly change by putting in place code that
parses the structured error and raises the same errors as it did when
parsing the response for the analagous errors.

Changelog: changed
      21d14354