Skip to content

Remove logging features via the :monitor_logging feature flag

Tristan Read requested to merge tr-remove-logging into master

What does this MR do and why?

Removes the Monitor > Logs feature and all associated product references. It does this by introducing a default_enabled: false feature flag around the existing features.

The flag state will be set to true on Staging and Production before merge, to ensure that no change occurs in GitLab.com until the %15.0 release.

Environment Status
Staging true - https://gitlab.slack.com/archives/CLM200USV/p1652252631539739
Production true - https://gitlab.slack.com/archives/C101F3796/p1652365972609859

issue: #360182 (closed)

Screenshots or screen recordings

name before after (with feature flag set to false)
Logs menu item monitor_logging_menu monitor_logging_menu_after
Logs page monitor_logging_page monitor_logging_page_after
Metrics dashboard panel monitor_logging_dashboard_2 monitor_logging_dashboard
Cluster integration settings monitor_logging_cluster_before monitor_logging_cluster
Environment deploy board pod link monitor_logging_pod monitor_logging_pod_after

How to set up and validate locally

Prerequisites for all:

  1. Disable the feature flag in the rails console: Feature.disable(:monitor_logging). This new flag is enabled by default.
  2. Be logged in as a maintainer or owner of a project.

Logs link

  1. Open your project
  2. The sub menu item Logs under the Monitor main menu item, should not exist

Logs page

  1. Open a project
  2. Navigate to <gdk-url>/<project>/-/logs
  3. You should see a 404

Monitor Dashboard

  1. Connect to a prometheus instance. Either on a cluster, or using https://gitlab.com/seanarnold/local-prometheus-metrics
  2. Navigate to Your-Project > Monitor > Metrics
  3. Select the dropdown for a dashboard panel.
  4. You should not see a 'View Logs' item.

Cluster page

  1. Connect a kubernetes cluster using the deprecated certificate method.
  2. Navigate to the cluster page.
  3. Select Integrations.
  4. You should not see a 'Enable Elastic Stack' option.

Environment pod logs link

  1. Connect a kubernetes cluster using the deprecated certificate method.
  2. Add a new environment within a folder.
  3. Ensure that there is at least one deployed environment.
  4. Navigate to the environments list.
  5. Navigate to the environment folder.
  6. Expand the deployment to see the pod status.
  7. The pod should not be a clickable link.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tristan Read

Merge request reports