Remove logging features via the :monitor_logging feature flag
What does this MR do and why?
Removes the Monitor > Logs feature and all associated product references. It does this by introducing a default_enabled: false
feature flag around the existing features.
The flag state will be set to true
on Staging and Production before merge, to ensure that no change occurs in GitLab.com until the %15.0 release.
Environment | Status |
---|---|
Staging |
true - https://gitlab.slack.com/archives/CLM200USV/p1652252631539739
|
Production |
true - https://gitlab.slack.com/archives/C101F3796/p1652365972609859
|
issue: #360182 (closed)
Screenshots or screen recordings
name | before | after (with feature flag set to false) |
---|---|---|
Logs menu item | ||
Logs page | ||
Metrics dashboard panel | ||
Cluster integration settings | ||
Environment deploy board pod link |
How to set up and validate locally
Prerequisites for all:
-
Disable the feature flag in the rails console:
Feature.disable(:monitor_logging)
. This new flag is enabled by default. - Be logged in as a maintainer or owner of a project.
Logs link
- Open your project
- The sub menu item Logs under the Monitor main menu item, should not exist
Logs page
- Open a project
- Navigate to
<gdk-url>/<project>/-/logs
- You should see a 404
Monitor Dashboard
- Connect to a prometheus instance. Either on a cluster, or using https://gitlab.com/seanarnold/local-prometheus-metrics
- Navigate to Your-Project > Monitor > Metrics
- Select the dropdown for a dashboard panel.
- You should not see a 'View Logs' item.
Cluster page
- Connect a kubernetes cluster using the deprecated certificate method.
- Navigate to the cluster page.
- Select Integrations.
- You should not see a 'Enable Elastic Stack' option.
Environment pod logs link
- Connect a kubernetes cluster using the deprecated certificate method.
- Add a new environment within a folder.
- Ensure that there is at least one deployed environment.
- Navigate to the environments list.
- Navigate to the environment folder.
- Expand the deployment to see the pod status.
- The pod should not be a clickable link.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Tristan Read