Skip to content

Pipeline tabs Vue migration - Jobs tab

What does this MR do and why?

Behind the disabled feature flag pipeline_tabs_vue, we now have Vue tabs in the pipeline page instead of Haml. However given how big the work is, we have divided each tab content into its own issue and MR. This specific issue is to migrate the jobs tab content to Vue.

We now pass the data from the rails helper method to the Vue app for the pipeline tabs and update the tests to now run for both the disabled and enabled pipeline_tabs_vue feature.

Step Issue Link MR link
Introduce the base tab layout in Vue behind a disabled feature flag #230749 (closed) !80401 (merged)
Support tab redirection None !85183 (merged)
Add the Pipeline and Dag tabs content #356198 (closed) !83418 (merged)
Add the Jobs tab content #360544 (closed) 👈🏻 you are here
Create new Vue component for Failed Jobs tab content #360656 (closed) cell
Add the Failed Jobs tab content #360798 (closed)
Add the Tests tab content #360794 (closed) cell
Add the the Security tab content #360795 (closed) cell
Add the the License tab content #360796 (closed) cell
Add the the Code Quality tab content 👈🏻 you are here cell
Feature flag rollout #353118 (closed)

Screenshots or screen recordings

Jobs tab

Before After
Screen_Shot_2022-04-26_at_2.26.19_PM Screen_Shot_2022-04-26_at_1.48.32_PM

How to set up and validate locally

  • Go to the pipeline page
  • Check that the jobs page renders as usual
  • Enable pipeline_tabs_vue feature flag
  • Notice that you can see the same tabs.
  • Notice that the jobs tab has a badge component with the total number of jobs
  • Click on jobs
  • Notice that it loads! (Lazy loading is working 🎉)
  • The jobs page content should be exactly the same.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #356198 (closed)

Related to #360544 (closed)

Edited by Frédéric Caplette

Merge request reports