Skip to content

Pipeline tabs Vue migration - Migrate Pipeline and Needs tab

What does this MR do and why?

Behind the disabled feature flag pipeline_tabs_vue, we now have Vue tabs in the pipeline page instead of Haml. However given how big the work is, we have divided each tab content into its own issue and MR. This specific issue is to migrate the pipeline and needs tab content to Vue.

We now pass the data from the rails helper method to the Vue app for the pipeline tabs and update the tests to now run for both the disabled and enabled pipeline_tabs_vue feature.

Please take note that the diff is wrong in the sense that a lot of it is just copy/pasted specs. If we remove all of that, we have a +80 diff instead of +2k 😅

Step Issue Link MR link
Introduce the base tab layout in Vue behind a disabled feature flag #230749 (closed) !80401 (merged)
Support tab redirection None !85183 (merged)
Add the Pipeline and Dag tabs content #356198 (closed) You are here 👈🏻
Add the Jobs tab content #360544 (closed) !85946 (merged)
Create new Vue component for Failed Jobs tab content #360656 (closed) cell
Add the Failed Jobs tab content #360798 (closed)
Add the Tests tab content #360794 (closed) cell
Add the the Security tab content #360795 (closed) cell
Add the the License tab content #360796 (closed) cell
Add the the Code Quality tab content #360797 (closed) cell
Feature flag rollout #353118 (closed)

Screenshots or screen recordings

Pipeline tab

Before After
Screen_Shot_2022-03-22_at_2.26.54_PM Screen_Shot_2022-03-22_at_2.23.55_PM

DAG tab

Before After
Screen_Shot_2022-03-22_at_2.27.04_PM Screen_Shot_2022-03-22_at_2.24.06_PM

How to set up and validate locally

  • Go to the pipeline page
  • Check that the pipeline and Needs page renders as usual
  • Enable pipeline_tabs_vue feature flag
  • Notice that you can see the same tabs.
  • The pipeline page and Needs page content should be exactly the same.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #356198 (closed)

Edited by Frédéric Caplette

Merge request reports