Introduce :gitlab_geo schema for Geo tracking DB
What does this MR do and why?
Add a :gitlab_geo
schema in lib/gitlab/database/gitlab_schemas.yml
similar to the separation between :gitlab_main
and :gitlab_ci
to ensure our query analyzers catch any cross-joins and cross-transactions.
Related to #358422 (closed)
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.0
added devopssystems groupgeo sectioncore platform typefeature + 1 deleted label
assigned to @dbalexandre
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @tkuah
,@rymai
,@DylanGriffith
,@tigerwnz
,@ayufan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
ee/db/geo/migrate/20210111911002_prepare_job_artifact_registry_for_ssf.rb
ee/db/geo/migrate/20210111912220_prepare_job_artifact_registry_for_ssf_indecies.rb
ee/db/geo/migrate/20220617125507_create_ci_secure_file_registry.rb
lib/gitlab/database/each_database.rb
lib/gitlab/database/gitlab_schema.rb
lib/gitlab/database/load_balancing.rb
lib/gitlab/database.rb
Documentation review
The following files require a review from a technical writer:
doc/development/database/multiple_databases.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 8.5 hours ahead of@dbalexandre
)Vasilii Iakliushin ( @vyaklushin
) (UTC+2, 5 hours ahead of@dbalexandre
)database Dmitry Gruzd ( @dgruzd
) (UTC+2, 5 hours ahead of@dbalexandre
)Diogo Frazão ( @dfrazao-gitlab
) (UTC+2, 5 hours ahead of@dbalexandre
)~migration No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 1532 commits
-
bff1efeb...202ecba5 - 1531 commits from branch
master
- 7ff145b2 - Introduce :gitlab_geo schema for Geo tracking DB
-
bff1efeb...202ecba5 - 1531 commits from branch
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 416a6790expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 548 commits
-
7ff145b2...35af524f - 547 commits from branch
master
- ed6ac440 - Introduce :gitlab_geo schema for Geo tracking DB
-
7ff145b2...35af524f - 547 commits from branch
added 153 commits
-
ed6ac440...921b31bc - 152 commits from branch
master
- 87b5d6b0 - Introduce :gitlab_geo schema for Geo tracking DB
-
ed6ac440...921b31bc - 152 commits from branch
added 24 commits
-
87b5d6b0...61335b6b - 23 commits from branch
master
- e3d14124 - Introduce :gitlab_geo schema for Geo tracking DB
-
87b5d6b0...61335b6b - 23 commits from branch
mentioned in issue #358422 (closed)
added 39 commits
-
e3d14124...5ed8277a - 38 commits from branch
master
- aa78fcbd - Introduce :gitlab_geo schema for Geo tracking DB
-
e3d14124...5ed8277a - 38 commits from branch
added 31 commits
-
aa78fcbd...7d703980 - 30 commits from branch
master
- bca1d3b8 - Introduce :gitlab_geo schema for Geo tracking DB
-
aa78fcbd...7d703980 - 30 commits from branch
- Resolved by Douglas Barbosa Alexandre
@cat Could you review, please?
requested review from @cat
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre