Introduce :gitlab_geo schema for Geo tracking DB
What does this MR do and why?
Add a :gitlab_geo
schema in lib/gitlab/database/gitlab_schemas.yml
similar to the separation between :gitlab_main
and :gitlab_ci
to ensure our query analyzers catch any cross-joins and cross-transactions.
Related to #358422 (closed)
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.0
added devopssystems groupgeo sectioncore platform typefeature + 1 deleted label
assigned to @dbalexandre
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @tkuah
,@rymai
,@DylanGriffith
,@tigerwnz
,@ayufan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
ee/db/geo/migrate/20210111911002_prepare_job_artifact_registry_for_ssf.rb
ee/db/geo/migrate/20210111912220_prepare_job_artifact_registry_for_ssf_indecies.rb
ee/db/geo/migrate/20220617125507_create_ci_secure_file_registry.rb
lib/gitlab/database/each_database.rb
lib/gitlab/database/gitlab_schema.rb
lib/gitlab/database/load_balancing.rb
lib/gitlab/database.rb
Documentation review
The following files require a review from a technical writer:
doc/development/database/multiple_databases.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+5.5, 8.5 hours ahead of@dbalexandre
)Vasilii Iakliushin ( @vyaklushin
) (UTC+2, 5 hours ahead of@dbalexandre
)database Dmitry Gruzd ( @dgruzd
) (UTC+2, 5 hours ahead of@dbalexandre
)Diogo Frazão ( @dfrazao-gitlab
) (UTC+2, 5 hours ahead of@dbalexandre
)~migration No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1532 commits
-
bff1efeb...202ecba5 - 1531 commits from branch
master
- 7ff145b2 - Introduce :gitlab_geo schema for Geo tracking DB
-
bff1efeb...202ecba5 - 1531 commits from branch
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 416a6790expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 548 commits
-
7ff145b2...35af524f - 547 commits from branch
master
- ed6ac440 - Introduce :gitlab_geo schema for Geo tracking DB
-
7ff145b2...35af524f - 547 commits from branch
added 153 commits
-
ed6ac440...921b31bc - 152 commits from branch
master
- 87b5d6b0 - Introduce :gitlab_geo schema for Geo tracking DB
-
ed6ac440...921b31bc - 152 commits from branch
added 24 commits
-
87b5d6b0...61335b6b - 23 commits from branch
master
- e3d14124 - Introduce :gitlab_geo schema for Geo tracking DB
-
87b5d6b0...61335b6b - 23 commits from branch
mentioned in issue #358422 (closed)
added 39 commits
-
e3d14124...5ed8277a - 38 commits from branch
master
- aa78fcbd - Introduce :gitlab_geo schema for Geo tracking DB
-
e3d14124...5ed8277a - 38 commits from branch
added 31 commits
-
aa78fcbd...7d703980 - 30 commits from branch
master
- bca1d3b8 - Introduce :gitlab_geo schema for Geo tracking DB
-
aa78fcbd...7d703980 - 30 commits from branch
- Resolved by Douglas Barbosa Alexandre
@cat Could you review, please?
requested review from @cat
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
removed review request for @cat
mentioned in issue gitlab-com/www-gitlab-com#12679 (closed)
@cat
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 326 commits
-
bca1d3b8...6e8f79e0 - 325 commits from branch
master
- 24f4b7df - Introduce :gitlab_geo schema for Geo tracking DB
-
bca1d3b8...6e8f79e0 - 325 commits from branch
added 1 commit
- 51c211c4 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
added 53 commits
-
51c211c4...cf08af2f - 52 commits from branch
master
- ff60f3a8 - Introduce :gitlab_geo schema for Geo tracking DB
-
51c211c4...cf08af2f - 52 commits from branch
mentioned in merge request !87420 (closed)
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
added 1106 commits
-
ff60f3a8...2139c19a - 1104 commits from branch
master
- d31dd62f - Introduce :gitlab_geo schema for Geo tracking DB
- ec89d087 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
-
ff60f3a8...2139c19a - 1104 commits from branch
added 222 commits
-
ec89d087...b9cb2c59 - 221 commits from branch
master
- a9133646 - Introduce :gitlab_geo schema for Geo tracking DB
-
ec89d087...b9cb2c59 - 221 commits from branch
added 210 commits
-
a9133646...0d6f03bf - 208 commits from branch
master
- 92c6b561 - Introduce :gitlab_geo schema for Geo tracking DB
- aa6c41c8 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
-
a9133646...0d6f03bf - 208 commits from branch
changed milestone to %15.1
added missed:15.0 label
mentioned in issue #363491 (closed)
mentioned in issue #358430 (closed)
mentioned in merge request !88080 (closed)
mentioned in merge request !88704 (merged)
added 2243 commits
-
aa6c41c8...597c8102 - 2240 commits from branch
master
- 9f2ee14e - Introduce :gitlab_geo schema for Geo tracking DB
- a27b293b - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- 75961603 - Introduce `gitlab_internal` for Rails and pg tables
Toggle commit list-
aa6c41c8...597c8102 - 2240 commits from branch
added 1 commit
- 539bb34f - Override check_postgres_version_and_print_warning
added workflowblocked label
I am marking it as blocked until we merge !88704 (merged).
added 1684 commits
-
788df734...e4a3f646 - 1680 commits from branch
master
- 3e81ef94 - Introduce :gitlab_geo schema for Geo tracking DB
- 95a0a8ea - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- 12f397f7 - Override check_postgres_version_and_print_warning
- a058faef - Exclude Geo connections
Toggle commit list-
788df734...e4a3f646 - 1680 commits from branch
added 816 commits
-
12f397f7...d938c0cb - 813 commits from branch
master
- c0ea4adc - Introduce :gitlab_geo schema for Geo tracking DB
- 8aa22c9d - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- d28059b8 - Override check_postgres_version_and_print_warning
Toggle commit list-
12f397f7...d938c0cb - 813 commits from branch
added 1 commit
- e8f9d4f7 - Fix allowed migration helper for migration timestamps
added 10 commits
-
9a990c46...ba07dcba - 6 commits from branch
master
- 512f9e33 - Introduce :gitlab_geo schema for Geo tracking DB
- 453631c7 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- 69dd8583 - Override check_postgres_version_and_print_warning
- a9e308f9 - Fix allowed migration helper for migration timestamps
Toggle commit list-
9a990c46...ba07dcba - 6 commits from branch
changed milestone to %15.2
added 16 commits
-
b38f9ef0...646f1947 - 12 commits from branch
master
- 9753a94c - Introduce :gitlab_geo schema for Geo tracking DB
- 94754f76 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- 402311e0 - Override check_postgres_version_and_print_warning
- 94373a09 - Fix allowed migration helper for migration timestamps
Toggle commit list-
b38f9ef0...646f1947 - 12 commits from branch
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
added 134 commits
-
94373a09...4c300636 - 130 commits from branch
master
- 9abebab7 - Introduce :gitlab_geo schema for Geo tracking DB
- 38f73db9 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
- 719240ef - Override check_postgres_version_and_print_warning
- 7dd0aa09 - Fix allowed migration helper for migration timestamps
Toggle commit list-
94373a09...4c300636 - 130 commits from branch
added 1 commit
- bd0eb89f - Introduce :gitlab_geo schema for Geo tracking DB
added 166 commits
-
bd0eb89f...0897e267 - 165 commits from branch
master
- 3f3a87f6 - Introduce :gitlab_geo schema for Geo tracking DB
-
bd0eb89f...0897e267 - 165 commits from branch
added 1 commit
- 11fc532b - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 2a9c12e3 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 18b8d335 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 0af37117 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 52ffb507 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 175a2ae3 - Introduce :gitlab_geo schema for Geo tracking DB
removed workflowblocked label
- Resolved by Douglas Barbosa Alexandre
@ayufan Do you mind having another look? They're still one spec to fix https://gitlab.com/gitlab-org/gitlab/-/jobs/2628059536. I'm still having a look, but if you have any idea
requested review from @ayufan
mentioned in issue #365761 (closed)
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
added 154 commits
-
175a2ae3...6e1d1b69 - 153 commits from branch
master
- 1fae9d8b - Introduce :gitlab_geo schema for Geo tracking DB
-
175a2ae3...6e1d1b69 - 153 commits from branch
added 1 commit
- 14ee3a8a - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- b400735c - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 83603b1d - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- c896b2b4 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 0cbc739c - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 76737fe2 - Introduce :gitlab_geo schema for Geo tracking DB
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
removed review request for @ayufan
added 1 commit
- 217a0090 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- edbacaa8 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 80b344d8 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 56cf2eec - Remove Geo::TrackingBase::SecondaryNotConfigured
added 1 commit
- 291328a5 - Introduce :gitlab_geo schema for Geo tracking DB
added pipeline:run-all-rspec label
removed pipeline:run-all-rspec label
- Resolved by Douglas Barbosa Alexandre
added 467 commits
-
291328a5...7af59d4f - 466 commits from branch
master
- b7d122a0 - Introduce :gitlab_geo schema for Geo tracking DB
-
291328a5...7af59d4f - 466 commits from branch
added 1 commit
- be77d6fb - Introduce :gitlab_geo schema for Geo tracking DB
- Resolved by Michael Kozono
@ayufan This is ready for another round of review. Do you mind having another look?
requested review from @ayufan
added 1 commit
- 4d1b328d - Introduce :gitlab_geo schema for Geo tracking DB
added 649 commits
-
4d1b328d...35db25ef - 648 commits from branch
master
- e6b92dc8 - Introduce :gitlab_geo schema for Geo tracking DB
-
4d1b328d...35db25ef - 648 commits from branch
- A deleted user
added backend database databasereview pending documentation labels
added 119 commits
-
e6b92dc8...f4b7218c - 118 commits from branch
master
- 4a93011a - Introduce :gitlab_geo schema for Geo tracking DB
-
e6b92dc8...f4b7218c - 118 commits from branch
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
- Resolved by Douglas Barbosa Alexandre
removed review request for @ayufan
added 40 commits
-
4a93011a...ece2a383 - 39 commits from branch
master
- 01f1cee1 - Introduce :gitlab_geo schema for Geo tracking DB
-
4a93011a...ece2a383 - 39 commits from branch
added 1 commit
- a80a3fc1 - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- 52bdc674 - Introduce :gitlab_geo schema for Geo tracking DB
mentioned in issue #366834
mentioned in issue #366835
added 1 commit
- 57b0884a - Introduce :gitlab_geo schema for Geo tracking DB
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @ayufan
added 388 commits
-
57b0884a...5396a6b6 - 387 commits from branch
master
- c3189657 - Introduce :gitlab_geo schema for Geo tracking DB
-
57b0884a...5396a6b6 - 387 commits from branch
added 358 commits
-
c3189657...af0d7a25 - 357 commits from branch
master
- 96557e86 - Introduce :gitlab_geo schema for Geo tracking DB
-
c3189657...af0d7a25 - 357 commits from branch
added 144 commits
-
96557e86...f9d01617 - 143 commits from branch
master
- 78f670b6 - Introduce :gitlab_geo schema for Geo tracking DB
-
96557e86...f9d01617 - 143 commits from branch
added 19 commits
-
78f670b6...6c2de6d5 - 18 commits from branch
master
- 0cea05f0 - Introduce :gitlab_geo schema for Geo tracking DB
-
78f670b6...6c2de6d5 - 18 commits from branch
- Resolved by Michael Kozono
- Resolved by Douglas Barbosa Alexandre
- Resolved by Michael Kozono
- Resolved by Douglas Barbosa Alexandre
removed review request for @mkozono
added 744 commits
-
0cea05f0...785e4268 - 743 commits from branch
master
- 82e725e8 - Introduce :gitlab_geo schema for Geo tracking DB
-
0cea05f0...785e4268 - 743 commits from branch
added 1 commit
- ac0fe5ea - Introduce :gitlab_geo schema for Geo tracking DB
added 1 commit
- f6851d5b - Introduce :gitlab_geo schema for Geo tracking DB
added 161 commits
-
f6851d5b...6a9ae90a - 160 commits from branch
master
- a2d022e8 - Introduce :gitlab_geo schema for Geo tracking DB
-
f6851d5b...6a9ae90a - 160 commits from branch
added 1 commit
- aae728a6 - Introduce :gitlab_geo schema for Geo tracking DB
requested review from @mkozono
added 75 commits
-
ea7b9784...61b21412 - 73 commits from branch
master
- 6cc4ae9a - Introduce :gitlab_geo schema for Geo tracking DB
- 416a6790 - Refactoring Gitlab::Database class
-
ea7b9784...61b21412 - 73 commits from branch
enabled an automatic merge when the pipeline for 7d3a1b94 succeeds
mentioned in commit 1f354c48
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
changed milestone to %15.3
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
mentioned in merge request !90633 (merged)
mentioned in merge request !108125 (merged)
mentioned in issue #387042 (closed)