Skip to content
Snippets Groups Projects

Introduce :gitlab_geo schema for Geo tracking DB

All threads resolved!

What does this MR do and why?

Add a :gitlab_geo schema in lib/gitlab/database/gitlab_schemas.yml similar to the separation between :gitlab_main and :gitlab_ci to ensure our query analyzers catch any cross-joins and cross-transactions.

Related to #358422 (closed)

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Douglas Barbosa Alexandre

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Catalin Irimie approved this merge request

    approved this merge request

  • Catalin Irimie removed review request for @cat

    removed review request for @cat

  • :wave: @cat, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • added 326 commits

    Compare with previous version

  • added 1 commit

    • 51c211c4 - Add geo to Gitlab::Database.gitlab_schemas_for_connection

    Compare with previous version

  • added 53 commits

    Compare with previous version

  • Kamil Trzciński mentioned in merge request !87420 (closed)

    mentioned in merge request !87420 (closed)

  • Kamil Trzciński
  • Kamil Trzciński
  • added 1106 commits

    • ff60f3a8...2139c19a - 1104 commits from branch master
    • d31dd62f - Introduce :gitlab_geo schema for Geo tracking DB
    • ec89d087 - Add geo to Gitlab::Database.gitlab_schemas_for_connection

    Compare with previous version

  • added 222 commits

    Compare with previous version

  • added 210 commits

    • a9133646...0d6f03bf - 208 commits from branch master
    • 92c6b561 - Introduce :gitlab_geo schema for Geo tracking DB
    • aa6c41c8 - Add geo to Gitlab::Database.gitlab_schemas_for_connection

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %15.1

    changed milestone to %15.1

  • mentioned in issue #363491 (closed)

  • Michael Kozono changed the description

    changed the description

  • mentioned in merge request !88080 (closed)

  • mentioned in merge request !88704 (merged)

  • added 2243 commits

    • aa6c41c8...597c8102 - 2240 commits from branch master
    • 9f2ee14e - Introduce :gitlab_geo schema for Geo tracking DB
    • a27b293b - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 75961603 - Introduce `gitlab_internal` for Rails and pg tables

    Compare with previous version

  • added 1 commit

    • 539bb34f - Override check_postgres_version_and_print_warning

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Douglas Barbosa Alexandre marked this merge request as draft

    marked this merge request as draft

  • I am marking it as blocked until we merge !88704 (merged).

  • added 1684 commits

    • 788df734...e4a3f646 - 1680 commits from branch master
    • 3e81ef94 - Introduce :gitlab_geo schema for Geo tracking DB
    • 95a0a8ea - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 12f397f7 - Override check_postgres_version_and_print_warning
    • a058faef - Exclude Geo connections

    Compare with previous version

  • added 816 commits

    • 12f397f7...d938c0cb - 813 commits from branch master
    • c0ea4adc - Introduce :gitlab_geo schema for Geo tracking DB
    • 8aa22c9d - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • d28059b8 - Override check_postgres_version_and_print_warning

    Compare with previous version

  • added 1 commit

    • e8f9d4f7 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 3 commits

    • f8d373cd - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 886b27db - Override check_postgres_version_and_print_warning
    • 9a990c46 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 10 commits

    • 9a990c46...ba07dcba - 6 commits from branch master
    • 512f9e33 - Introduce :gitlab_geo schema for Geo tracking DB
    • 453631c7 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 69dd8583 - Override check_postgres_version_and_print_warning
    • a9e308f9 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 3 commits

    • 42db9eb1 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • e9b637ce - Override check_postgres_version_and_print_warning
    • b38f9ef0 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • changed milestone to %15.2

  • added 16 commits

    • b38f9ef0...646f1947 - 12 commits from branch master
    • 9753a94c - Introduce :gitlab_geo schema for Geo tracking DB
    • 94754f76 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 402311e0 - Override check_postgres_version_and_print_warning
    • 94373a09 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 134 commits

    • 94373a09...4c300636 - 130 commits from branch master
    • 9abebab7 - Introduce :gitlab_geo schema for Geo tracking DB
    • 38f73db9 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 719240ef - Override check_postgres_version_and_print_warning
    • 7dd0aa09 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 3 commits

    • 4b2ae113 - Add geo to Gitlab::Database.gitlab_schemas_for_connection
    • 4550bbc2 - Override check_postgres_version_and_print_warning
    • f14937c0 - Fix allowed migration helper for migration timestamps

    Compare with previous version

  • added 1 commit

    • bd0eb89f - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 166 commits

    Compare with previous version

  • added 1 commit

    • 11fc532b - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 2a9c12e3 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 18b8d335 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 0af37117 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 52ffb507 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 175a2ae3 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • resolved all threads

  • requested review from @ayufan

  • mentioned in issue #365761 (closed)

  • added 154 commits

    Compare with previous version

  • added 1 commit

    • 14ee3a8a - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • b400735c - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 83603b1d - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • c896b2b4 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 0cbc739c - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 76737fe2 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • Kamil Trzciński
  • Kamil Trzciński
  • Kamil Trzciński removed review request for @ayufan

    removed review request for @ayufan

  • added 1 commit

    • 217a0090 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • edbacaa8 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 80b344d8 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 2 commits

    • 6f2653aa - Introduce :gitlab_geo schema for Geo tracking DB
    • 936ccc36 - Remove Geo::TrackingBase::SecondaryNotConfigured

    Compare with previous version

  • added 2 commits

    • d12733c5 - Introduce :gitlab_geo schema for Geo tracking DB
    • 5d140d0b - Remove Geo::TrackingBase::SecondaryNotConfigured

    Compare with previous version

  • added 1 commit

    • 56cf2eec - Remove Geo::TrackingBase::SecondaryNotConfigured

    Compare with previous version

  • added 1 commit

    • 291328a5 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 467 commits

    Compare with previous version

  • added 1 commit

    • be77d6fb - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • requested review from @ayufan

  • Douglas Barbosa Alexandre marked this merge request as ready

    marked this merge request as ready

  • added 1 commit

    • 4d1b328d - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 649 commits

    Compare with previous version

  • added 119 commits

    Compare with previous version

  • Kamil Trzciński
  • Kamil Trzciński removed review request for @ayufan

    removed review request for @ayufan

  • added 40 commits

    Compare with previous version

  • added 1 commit

    • a80a3fc1 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 52bdc674 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • mentioned in issue #366834

  • mentioned in issue #366835

  • added 1 commit

    • 57b0884a - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • Douglas Barbosa Alexandre marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • requested review from @ayufan

  • added 388 commits

    Compare with previous version

  • added 358 commits

    Compare with previous version

  • added 144 commits

    Compare with previous version

  • added 19 commits

    Compare with previous version

  • Kamil Trzciński approved this merge request

    approved this merge request

  • Kamil Trzciński requested review from @mkozono and removed review request for @ayufan

    requested review from @mkozono and removed review request for @ayufan

  • Michael Kozono
  • Michael Kozono
  • Michael Kozono removed review request for @mkozono

    removed review request for @mkozono

  • added 744 commits

    Compare with previous version

  • added 1 commit

    • ac0fe5ea - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • f6851d5b - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 161 commits

    Compare with previous version

  • added 1 commit

    • aae728a6 - Introduce :gitlab_geo schema for Geo tracking DB

    Compare with previous version

  • added 1 commit

    • 8f8e4a92 - Refactoring Gitlab::Database class

    Compare with previous version

  • added 1 commit

    • ea7b9784 - Refactoring Gitlab::Database class

    Compare with previous version

  • requested review from @mkozono

  • Michael Kozono approved this merge request

    approved this merge request

  • Michael Kozono resolved all threads

    resolved all threads

  • I'll do /rebase since the CI job failure looks like one of those that might need it

  • Michael Kozono added 75 commits

    added 75 commits

    Compare with previous version

  • Michael Kozono enabled an automatic merge when the pipeline for 7d3a1b94 succeeds

    enabled an automatic merge when the pipeline for 7d3a1b94 succeeds

  • Michael Kozono mentioned in commit 1f354c48

    mentioned in commit 1f354c48

  • added workflowstaging label and removed workflowcanary label

  • changed milestone to %15.3

  • Dmitry Gruzd mentioned in merge request !90633 (merged)

    mentioned in merge request !90633 (merged)

  • Rutger Wessels mentioned in merge request !108125 (merged)

    mentioned in merge request !108125 (merged)

  • mentioned in issue #387042 (closed)

  • Please register or sign in to reply
    Loading