Fix Hover/Active state in sidebar navigation
What does this MR do and why?
In !83593 (merged) the active class was changed to use the --nav-active-bg variable which was removed in a later commit in the same MR.
I have seen no issues locally in GDK after reverting this commit.
Using Find in Files, it looks like this variable is referenced 17 times (21 - 4 times variable declaration) across 6 file. With this revert, only 4 files are changed, so this variable was referenced in 2 other files without the variable actually being present.
This reverts commit 08971448.
This adds the --nav-active-bg variable to the dark theme in order to fix the active and hover state, which already referenced this variable while it was not present in the dark theme.
Related to #357154 (closed)
Screenshots or screen recordings
Change for Dark Theme
| 14.9.3-ee | SaaS (14.11.0-pre 5f2f4368) | After this MR |
|---|---|---|
 |
 |
 |
No impact to Light Theme
| 14.9.3-ee | SaaS (14.11.0-pre 4fcad89e) | After this MR |
|---|---|---|
 |
 |
 |
How to set up and validate locally
Checkout the branch and start GDK
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN. - You can comment
@gitlab-bot label ~"group::<group name>"to add a group label or@gitlab-bot label ~"type::<type name>"to add a type label. - If you need help moving the MR forward or finding a reviewer, feel free to ask
@gitlab-bot helpor ping a Merge Request Coach. - Read more on how to get help.
- You can provide feedback on the GitLab Contributor Experience in this survey
This message was generated automatically. You're welcome to improve it.
added Community contribution label
assigned to @Taucher2003
2 Warnings 
This MR changes code in ee/, but its Changelog commit is missing theEE: truetrailer. Consider adding it to your Changelog commits.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.If needed, you can retry the
danger-reviewjob that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Stanislav Lashmanov ( @slashmanov) (UTC+4)Kushal Pandya ( @kushalpandya) (UTC+5.5)UX Austin Regnery ( @aregnery) (UTC-4)No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Edited by Taucher2003 Botmentioned in issue #345513
mentioned in issue gitlab-org/quality/triage-reports#7262 (closed)
- Resolved by Natalia Tepluhina
@Taucher2003 thanks for your contribution!
Not sure if this is ready for a review, but I'll already ping @mle @janis who worked on !83593 (merged) for their input.
- Last reply by Natalia Tepluhina
changed milestone to %15.0
-
Setting label(s) devopsecosystem sectiondev based on groupfoundations.
added sectiondev + 1 deleted label
added 2 commits
added 249 commits
-
ef7c1492...2eb756a9 - 248 commits from branch
gitlab-org:master - a0eb74bb - Fix the active state of sidebar navigation
-
ef7c1492...2eb756a9 - 248 commits from branch
