Skip to content

Fix Hover/Active state in sidebar navigation

Niklas van Schrick requested to merge taucher2003-group/gitlab:357154-hover-active-effects-in-sidebar-missing into master

What does this MR do and why?

In !83593 (merged) the active class was changed to use the --nav-active-bg variable which was removed in a later commit in the same MR.
I have seen no issues locally in GDK after reverting this commit.

Using Find in Files, it looks like this variable is referenced 17 times (21 - 4 times variable declaration) across 6 file. With this revert, only 4 files are changed, so this variable was referenced in 2 other files without the variable actually being present.

This reverts commit 08971448.

This adds the --nav-active-bg variable to the dark theme in order to fix the active and hover state, which already referenced this variable while it was not present in the dark theme.

Related to #357154 (closed)

Screenshots or screen recordings

Change for Dark Theme

14.9.3-ee SaaS (14.11.0-pre 5f2f4368) After this MR
image image image

No impact to Light Theme

14.9.3-ee SaaS (14.11.0-pre 4fcad89e) After this MR
image image image

How to set up and validate locally

Checkout the branch and start GDK

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Niklas van Schrick

Merge request reports