Remove `admin_application_settings_service_usage_data_center` FF
What does this MR do and why?
admin_application_settings_service_usage_data_center
was successfully tested, this MR removes it.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #351268 (closed)
Merge request reports
Activity
changed milestone to %14.10
assigned to @nbelokolodov
added 1 commit
- 076821ae - Remove admin_application_settings_service_usage_data_center feature flag
added 1 commit
- c9e11e00 - Remove admin_application_settings_service_usage_data_center feature flag
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/development/service_ping/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jason Goodman ( @jagood
) (UTC-4, 17 hours behind@nbelokolodov
)James Fargher ( @proglottis
) (UTC+13, same timezone as@nbelokolodov
)frontend Coung Ngo ( @cngo
) (UTC+0, 13 hours behind@nbelokolodov
)Paul Slaughter ( @pslaughter
) (UTC-5, 18 hours behind@nbelokolodov
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 1 commit
- 583f6d70 - Remove admin_application_settings_service_usage_data_center feature flag
Allure report
allure-report-publisher
generated test report for ef597de6!review-qa-smoke:
test report
review-qa-reliable: test report- Resolved by Paul SlaughterEdited by Niko Belokolodov
requested review from @jagood
- Resolved by Paul Slaughter
requested review from @cngo
requested review from @pslaughter and removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Setting label(s) Category:Service Ping based on ~"group::product intelligence".
added Category:Service Ping label
removed [deprecated] Accepting merge requests label
removed review request for @jagood
added 1 commit
- ef597de6 - Remove admin_application_settings_service_usage_data_center feature flag
@proglottis could you please review the backend part?
added workflowin review label and removed workflowin dev label
requested review from @proglottis
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/development/service_ping/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov ( @vsizov
) (UTC+1, 12 hours behind@nbelokolodov
)Bob Van Landuyt ( @reprazent
) (UTC+2, 11 hours behind@nbelokolodov
)frontend Payton Burdette ( @pburdette
) (UTC-4, 17 hours behind@nbelokolodov
)Natalia Tepluhina ( @ntepluhina
) (UTC+2, 11 hours behind@nbelokolodov
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerremoved review request for @proglottis
- Resolved by Paul Slaughter
enabled an automatic merge when the pipeline for 6e214dac succeeds
mentioned in commit 832b0700
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in commit 3fabeae1
mentioned in commit c9754947
mentioned in commit 87c6163a
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #351268 (closed)
mentioned in merge request kubitus-project/kubitus-installer!918 (merged)