Skip to content
Snippets Groups Projects

Use GlBroadcastMessage in Broadcast Message admin settings page

What does this MR do and why?

Closes #325352 (closed)

This MR intends to migrate to GlBroadcastMessage as defined in the gitlab-ui and Pajamas Design System.

The component itself was migrated to Rails version in shared/_broadcast_message.html.haml.

The settings page has undergone a breaking change. Background color option was removed. Instead, there's a new option called Theme, which uses available themes from the GlBroadcastMessage component.

The visual design for the banner type has also changed and is now Pajamas-compliant. The notification type was left intact.

The messages configured prior to this change will receive a default indigo theme.

Screenshots or screen recordings

Before After
image image
image image
image image

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stanislav Lashmanov

Merge request reports

Merged results pipeline #519224597 passed

Pipeline: GitLab

#519235485

    Merged results pipeline passed for cf37e50f

    Test coverage 88.76% (0.13%) from 2 jobs

    Merged by Mark ChaoMark Chao 2 years ago (Apr 19, 2022 2:56am UTC)

    Loading

    Pipeline #519248903 passed

    Pipeline passed for a205ea1a on master

    Test coverage 79.48% (0.13%) from 2 jobs
    8 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply
    Loading