Build jobs filtered search
What does this MR do and why?
This MR builds a jobs filtered search feature on-top of the new jobs table in Vue/GraphQL. Currently behind the jobs_table_vue
feature flag (roll out coming soon). Filtered search part of this MR is behind a new dedicated FF jobs_table_vue_search
.
We also change a few loading state things to prevent a bug from happening when switching tabs. Stale data was getting loaded when switching tabs briefly.
Screenshots or screen recordings
How to set up and validate locally
- Enable
jobs_table_vue
andjobs_table_vue_search
. - Visit a project with CI and Jobs
- Navigate to CI/CD > Jobs
- Test out filtered search
- Test out switching tabs
- Test out infinite scrolling if your project has more than 30 jobs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #293862 (closed)
Merge request reports
Activity
changed milestone to %15.0
assigned to @pburdette
2 Warnings This merge request is quite big (503 lines changed), please consider splitting it into multiple merge requests. 8178a84e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan ( @sashi_kumar
) (UTC+0, 4 hours ahead of@pburdette
)Mayra Cabrera ( @mayra-cabrera
) (UTC-6, 2 hours behind@pburdette
)frontend Florie Guibert ( @fguibert
) (UTC+10, 14 hours ahead of@pburdette
)Paul Slaughter ( @pslaughter
) (UTC-5, 1 hour behind@pburdette
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8aaf26ce and 61546c20
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.7 MB 3.7 MB - 0.0 % mainChunk 2.32 MB 2.32 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.jobs.index 1.07 MB 1.16 MB +98.79 KB 9.0 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 8aaf26ce. So we have used data from: 608f21b0.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved needs weight label
Allure report
allure-report-publisher
generated test report for 61546c20!review-qa-smoke:
test report
review-qa-reliable: test report
package-and-qa-ff-disabled: test report
package-and-qa-ff-enabled: test reportadded 667 commits
-
e752e11d...c33668ee - 665 commits from branch
master
- d87a0186 - Build jobs filtered search
- 644bc08c - Changes the cache config and the specs
-
e752e11d...c33668ee - 665 commits from branch
TODO:
- Add test coverage
- Put changes behind feature flag
- Create issue to update tab count (Issue here #356278 (closed))
Edited by Payton Burdette- Resolved by Payton Burdette
@v_mishra would you mind giving this a UX review? I left instructions on how to setup in description along with a screen recording.
One thing we may want to do is do the grey background like we do on pipelines
requested review from @v_mishra
mentioned in merge request !83132 (merged)
mentioned in issue #356210 (closed)
removed workflowplanning breakdown label
added 1339 commits
-
46e8bdbe...21b43cde - 1338 commits from branch
master
- a6553f51 - Build jobs filtered search
-
46e8bdbe...21b43cde - 1338 commits from branch
removed review request for @v_mishra
@v_mishra
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
changed milestone to %14.10
mentioned in issue #356278 (closed)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
@fguibert can you do the first review please?
FYI I'd like
@jivanvl
to do the maintainer review here since he has a lot of context hereEdited by Payton Burdette
requested review from @fguibert
- Resolved by Payton Burdette
@sashi_kumar can you review BE please?
requested review from @sashi_kumar
requested review from @mayra-cabrera and removed review request for @sashi_kumar
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
mentioned in issue #327500 (closed)