Expose membership_lock on group detail API
What does this MR do and why?
This MR exposes the membership_lock
field so this can be implemented as part of the GitLab Terraform provider.
How to set up and validate locally
- Run in EE
- Update a group via an API call to set
membership_locked
totrue
- Validate that
membership_locked
returns in the API response and any GET responses for group details.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - When you feel your MR (merge request) is ready for a review, just ask
@gitlab-bot request_review
and someone will take a look. - If you are stuck, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
- You can provide feedback on the GitLab Contributor Experience in this survey
This message was generated automatically. You're welcome to improve it.
added Community contribution label
assigned to @jtymes
added 113 commits
-
873ce6cf...d5dfee6a - 112 commits from branch
gitlab-org:master
- 7c5ef365 - Expose membership_lock on group detail API
-
873ce6cf...d5dfee6a - 112 commits from branch
added 1st contribution label
mentioned in issue gitlab-org/quality/triage-reports#6776 (closed)
@hfyngvason Can you review this Community contribution if you are available?/cc @nicholasklick as EM according to https://about.gitlab.com/handbook/product/categories/#configure-group
requested review from @hfyngvason
- Resolved by Hordur Freyr Yngvason
Thanks @jtymes! This makes sense to me
Since a user can update this field, I think they should also be able to see it.
The only problem are the test failures, but I'm unable to reproduce those locally. Re-running the pipeline to see if it helps.
- Resolved by Hordur Freyr Yngvason
@jtymes Actually, there's two more things:
-
Since this touches the API, the commit message needs an EE changelog trailer.
-
The docs should be updated with a note of the form:
Users of GitLab Premium or higher also see the
membership_lock
attribute:{ "id": 4, "description": "Aliquid qui quis dignissimos distinctio ut commodi voluptas est.", "membership_lock": false, ... }
Please put the note following the similar note for the
marked_for_deletion_on
field. Thanks!
Edited by Hordur Freyr Yngvason -
- Resolved by Evan Read
Hi @eread, please review this documentation Merge Request.
added twtriaged label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/groups.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Niko Belokolodov ( @nbelokolodov
) (UTC+13)Etienne Baqué ( @ebaque
) (UTC+3)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerEdited by Jeremy Tymes- Resolved by Mikołaj Wawrzyniak
@hfyngvason
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added sectionops label
- Resolved by Mikołaj Wawrzyniak
Thanks @jtymes! This LGTM
I'm just waiting for confirmation from the team responsible for this API that there are no issues exposing the field, on the off chance that it was excluded from the API on purpose. Once I have the green light, I will pass this on to a maintainer.
added devopsmanage groupauthentication and authorization [DEPRECATED] labels and removed devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] labels
requested review from @eread
removed review request for @eread
changed milestone to %14.9
added Technical Writing docsfeature typemaintenance labels and removed typefeature label
added 580 commits
-
4057bd92...6a5a8458 - 579 commits from branch
gitlab-org:master
- 79c4fb96 - Expose membership_lock on group detail API
-
4057bd92...6a5a8458 - 579 commits from branch
requested review from @dblessing and removed review request for @hfyngvason
- Resolved by Jeremy Tymes
Thank you for contributing, @jtymes
requested review from @mikolaj_wawrzyniak and removed review request for @dblessing
added 1782 commits
-
98f89400...456365c3 - 1781 commits from branch
gitlab-org:master
- 949a5128 - Expose membership_lock on group detail API
-
98f89400...456365c3 - 1781 commits from branch
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/groups.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Zamir Martins Filho ( @zmartins
) (UTC-4)Charlie Ablett ( @cablett
) (UTC+13)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerchanged milestone to %14.10
- Resolved by Evan Read
enabled an automatic merge when the pipeline for 46fb8644 succeeds
Thank you very much @jtymes I'm very sorry for long response time, I was out of office last week.
Edit: MR is in great shape, let's ship it
Edited by Mikołaj WawrzyniakHi @jtymes,
We would love to know how you found your code review experience in this merge request! Please leave a
or a on this comment to describe your experience.Once done, please comment
@gitlab-bot feedback
below and feel free to leave any additional feedback you have in the same comment.You can also fill out a 5 minute survey to provided additional feedback on how GitLab can improve the contributor experience.
Thanks for your help!
mentioned in commit da36575a