Skip to content
Snippets Groups Projects

Expose membership_lock on group detail API

Merged Jeremy Tymes requested to merge jtymes/gitlab:membership_lock-api into master

What does this MR do and why?

This MR exposes the membership_lock field so this can be implemented as part of the GitLab Terraform provider.

How to set up and validate locally

  1. Run in EE
  2. Update a group via an API call to set membership_locked to true
  3. Validate that membership_locked returns in the API response and any GET responses for group details.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jeremy Tymes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jeremy Tymes added 1 commit

    added 1 commit

    • 98f89400 - Expose membership_lock on group detail API

    Compare with previous version

  • Evan Read approved this merge request

    approved this merge request

  • Thank you for contributing, @jtymes :star:

  • Drew Blessing requested review from @mikolaj_wawrzyniak and removed review request for @dblessing

    requested review from @mikolaj_wawrzyniak and removed review request for @dblessing

  • Mikołaj Wawrzyniak added 1782 commits

    added 1782 commits

    Compare with previous version

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    • doc/api/groups.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Zamir Martins Filho (@zmartins) (UTC-4) Charlie Ablett (@cablett) (UTC+13)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Generated by :no_entry_sign: Danger

  • Mikołaj Wawrzyniak changed milestone to %14.10

    changed milestone to %14.10

  • added 1 commit

    • 79174d49 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Mikołaj Wawrzyniak resolved all threads

    resolved all threads

  • Mikołaj Wawrzyniak enabled an automatic merge when the pipeline for 46fb8644 succeeds

    enabled an automatic merge when the pipeline for 46fb8644 succeeds

  • Thank you very much @jtymes I'm very sorry for long response time, I was out of office last week.

    Edit: MR is in great shape, let's ship it :ship:

    Edited by Mikołaj Wawrzyniak
  • Mikołaj Wawrzyniak approved this merge request

    approved this merge request

  • Hi @jtymes,

    We would love to know how you found your code review experience in this merge request! Please leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.

    Once done, please comment @gitlab-bot feedback below and feel free to leave any additional feedback you have in the same comment.

    You can also fill out a 5 minute survey to provided additional feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

  • mentioned in commit da36575a

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading