Skip to content

Remove "Add Sbom Survey Banner"

- requested to merge 350903-remove-sbom-survey-banner into master

What does this MR do and why?

Removes sbom survey banner.

Removal strategy

  • Revert commit 3c70b090 from MR !76446 (merged) to reduce risk of missing something
  • Manually and carefully resolve merge conflicts caused by a more recent refactor !77583 (diffs)
  • Do not remove the re-usable ee/app/assets/javascripts/vue_shared/survey_banner/survey_banner.vue component so we can add banners easily in the future.
  • Add changelog entry
  • Manually test removal

And it's all about this Banner:

sbomBanner
Screenshot_2021-12-13_at_18.35.04

It introduced a new vue_shared component survey_banner which was to be configured via props and would render a Banner like in the screenshot above.

Furthermore this new shared component is used to display the sbom Banner on the dependency list page, license compliance page, group and project security dashboards.

The Banner had a link, the ability to be dismissed (saved in LocalStorage) and the ability to be reminded in a given number of days.

It was behind the sbom_survey feature flag roll out issue: #348181 (closed)

ticipate in the discussion. -->

Screenshots or screen recordings (things that were removed)

dependency scanning license compliance security dashboard
Screenshot_2021-12-13_at_18.22.10 Screenshot_2021-12-13_at_18.23.50 Screenshot_2021-12-13_at_18.18.25

How to set up and validate locally

  1. enable the sbom_survey feature flag
  2. rails c
  3. Feature.enable(:sbom_survey)
  4. Make sure to clear up Local Storage before testing
  5. check if the banner does not display on the dependency list page http://gitlab.localdev:3000/GROUP/PROJECT/-/dependencies
  6. check if the banner does not display on the license compliance page http://gitlab.localdev:3000/GROUP/PROJECT/-/licenses
  7. check if the banner does not display on the project security dashboard http://gitlab.localdev:3000/GROUP/PROJECT/-/security/dashboard
  8. check if the banner does not display on thee group security dashboard http://gitlab.localdev:3000/groups/$GROUP/-/security/dashboard

Related to #350903 (closed)

Edited by -

Merge request reports