Respect webpack live reload setting
What does this MR do and why?
When we updated the webpack-dev-server, we just used DEV_SERVER_LIVERELOAD to control hot module reloading. When in fact we want to control "normal" live reloading as well.
Furthermore we can disable the websocket server that would be started allTogether in order to save some resources.
Screenshots or screen recordings
N/A
How to set up and validate locally
- Set
webpack.live_reload: false
in thegdk.yml
, then run ingdk
folder: make Procfile
gdk restart webpack
- Change a JavaScript file (e.g. adding a console.log to
main.js
) and see that nothing reloads. Furthermore your browser should not try to make any web socket connection.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lukas 'ai-pi' Eipert