Skip to content

Respect webpack live reload setting

Lukas 'ai-pi' Eipert requested to merge leipert-disable-live-reload into master

What does this MR do and why?

When we updated the webpack-dev-server, we just used DEV_SERVER_LIVERELOAD to control hot module reloading. When in fact we want to control "normal" live reloading as well.

Furthermore we can disable the websocket server that would be started allTogether in order to save some resources.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Set webpack.live_reload: false in the gdk.yml, then run in gdk folder:
  2. make Procfile
  3. gdk restart webpack
  4. Change a JavaScript file (e.g. adding a console.log to main.js) and see that nothing reloads. Furthermore your browser should not try to make any web socket connection.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports