Skip to content

EE port of "backport SSH host key detection code to CE"

Nick Thomas requested to merge (removed):ee-49565-ssh-push-mirroring into master

What does this MR do?

EE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22577

This is important preparatory work for the %11.5 deliverable: https://gitlab.com/gitlab-org/gitlab-ce/issues/49565

In addition to moving some code to CE, we also need to modify how the existing pull mirroring frontend uses the SSH host key lookup endpoint. Instead of assuming that the previous host keys are stored in the ProjectImportData model for the project, the frontend passes the current value to the endpoint directly. This is a large urlencoded string, but it shouldn't generally push the URL length over 2048 bytes - it's ~600 bytes on my installation, for instance. Still, I'm open to this changing so we pass the parameters in the request body instead, if necessary.

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/49565

Does this MR meet the acceptance criteria?

Edited by Nick Thomas

Merge request reports