Skip to content
Snippets Groups Projects

Link by commit and name for pipeline

Merged Payton Burdette requested to merge 337496-link-by-name-not-id-pipelines into master
All threads resolved!

What does this MR do and why?

Links to pipeline by commit title rather than pipeline ID.

Screenshots or screen recordings

before after
Screen_Shot_2022-02-14_at_11.59.35_AM Screen_Shot_2022-02-14_at_11.51.37_AM

How to set up and validate locally

  1. Behind rearrange_pipelines_table enabled true
  2. Visit pipelines table

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337496 (closed)

Edited by Payton Burdette

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jannik Lehmann approved this merge request

    approved this merge request

  • Good job @pburdette ! I was able to reproduce the behaviour, changes look good to. Just a small non-blocking nitpick for your consideration.

    @jivanvl Could you take over for maintainer review?

  • Jannik Lehmann requested review from @jivanvl and removed review request for @jannik_lehmann

    requested review from @jivanvl and removed review request for @jannik_lehmann

  • Richard Chong approved this merge request

    approved this merge request

  • Jose Ivan Vargas resolved all threads

    resolved all threads

  • Jose Ivan Vargas approved this merge request

    approved this merge request

  • Looks good to me! Thanks Payton

  • Jose Ivan Vargas enabled an automatic merge when the pipeline for 0713f8b7 succeeds

    enabled an automatic merge when the pipeline for 0713f8b7 succeeds

  • mentioned in commit cf91279d

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Sam Beckham mentioned in commit 7c2eca58

    mentioned in commit 7c2eca58

  • mentioned in issue #353387 (closed)

  • Please register or sign in to reply
    Loading