Exit registration verification
What does this MR do and why?
This adds an Exit
link to the required verification page, when the require_verification_for_namespace_creation
experiment is enabled, which allows the user to skip credit card verification and group + project creation during signup. It can be toggled through a feature flag.
Issue: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/559
Screenshots or screen recordings
How to set up and validate locally
- Enable the
combined_registration
experimentFeature.enable(:combined_registration)
- Enable the
require_verification_for_namespace_creation
experimentFeature.enable(:require_verification_for_namespace_creation)
- Enable the
exit_registration_verification
feature flagFeature.enable(:exit_registration_verification)
- Visit the combined registration page:
http://localhost:3000/users/sign_up/groups_projects/new
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
added devopsgrowth featureaddition groupactivation sectiongrowth typefeature labels
assigned to @alexbuijs
added 1 commit
- b89a097b - Add exit link to required verification when onboarding
- A deleted user
added backend feature flag frontend labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Reuben Pereira ( @rpereira2
) (UTC+5.5, 4.5 hours ahead of@alexbuijs
)Marc Shaw ( @marc_shaw
) (UTC+5.5, 4.5 hours ahead of@alexbuijs
)frontend Tristan Read ( @tristan.read
) (UTC+13, 12 hours ahead of@alexbuijs
)Brandon Labuschagne ( @blabuschagne
) (UTC+1, same timezone as@alexbuijs
)test Quality for spec/features/*
Reuben Pereira ( @rpereira2
) (UTC+5.5, 4.5 hours ahead of@alexbuijs
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed backend feature flag frontend labels
added 1 commit
- 9c0317bb - Add exit link to required verification when onboarding
- A deleted user
added backend feature flag frontend labels
Allure report
allure-report-publisher
generated test report for 95ea4682!review-qa-reliable:
test report
package-and-qa-ff-disabled: test report
package-and-qa-ff-enabled: test report
review-qa-smoke: test reportadded 1 commit
- 02a46025 - Add exit link to required verification when onboarding
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits dcb79f33 and 95ea4682
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.69 MB 3.67 MB -12.08 KB -0.3 % mainChunk 2.3 MB 2.29 MB -4.68 KB -0.2 % Significant Growth: 55Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.shared.permissions 858.63 KB 883.82 KB +25.19 KB 2.9 % pages.projects.work_items 897.63 KB 922.39 KB +24.76 KB 2.8 % pages.projects 800.88 KB 825.24 KB +24.36 KB 3.0 % pages.projects.activity 809.65 KB 834.01 KB +24.36 KB 3.0 % pages.projects.artifacts.browse 802.71 KB 827.07 KB +24.36 KB 3.0 % pages.projects.artifacts.file 812.65 KB 837 KB +24.36 KB 3.0 % pages.projects.blame.show 900.13 KB 924.49 KB +24.36 KB 2.7 % pages.projects.blob.edit 885.96 KB 910.32 KB +24.36 KB 2.7 % pages.projects.blob.new 885.96 KB 910.32 KB +24.36 KB 2.7 % pages.projects.branches.new 805.07 KB 829.43 KB +24.36 KB 3.0 % The table above is limited to 10 entries. Please look at the full report for more details
Significant Reduction: 65Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.usage_quotas 4.74 MB 1.05 MB -3.69 MB -77.9 % pages.groups.usage_quotas.pending_members 4.75 MB 1.06 MB -3.69 MB -77.7 % pages.admin.runners.show 986.94 KB 861.23 KB -125.71 KB -12.7 % pages.projects.cluster_agents.show 1.89 MB 1.82 MB -76.2 KB -3.9 % pages.projects.security.vulnerabilities.new 1.86 MB 1.82 MB -45.49 KB -2.4 % pages.projects.integrations.jira.issues.show 1.31 MB 1.28 MB -40.39 KB -3.0 % pages.projects.integrations.zentao.issues.show 1.31 MB 1.27 MB -40.39 KB -3.0 % pages.groups.group_members 657.97 KB 618.21 KB -39.76 KB -6.0 % pages.groups.epics.new 1.45 MB 1.41 MB -38.72 KB -2.6 % pages.projects.releases.edit 1.32 MB 1.29 MB -37.81 KB -2.8 % The table above is limited to 10 entries. Please look at the full report for more details
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for dcb79f33. So we have used data from: af4201c9.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 164 commits
-
02a46025...efb701f1 - 163 commits from branch
master
- 4fc7c09b - Add exit link to required verification when onboarding
-
02a46025...efb701f1 - 163 commits from branch
- Resolved by Careem Ahamed
Hi @rcobb! Could you review backend please?
Hi @justin_ho! Could you review frontend please?
requested review from @rcobb and @justin_ho
- Resolved by Alex Buijs
- Resolved by Alex Buijs
removed review request for @justin_ho
@justin_ho
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 1 commit
- 21689fb8 - Add exit link to required verification when onboarding
requested review from @blabuschagne
removed review request for @rcobb
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
removed review request for @blabuschagne
added 1 commit
- 95ea4682 - Add exit link to required verification when onboarding
requested review from @blabuschagne
requested review from @alexpooley
The
package-and-qa-ff-disabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/473960931 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/473975491 downstream.The
package-and-qa-ff-enabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/473960931 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/473975494 downstream.The
gitlab-qa
downstream pipeline failed! .The
gitlab-qa
downstream pipeline failed! .
removed review request for @blabuschagne
added UX label
requested review from @huzaifaiftikhar1
removed review request for @huzaifaiftikhar1
- Resolved by Alex Pooley
requested review from @cahamed
requested review from @vincywilson and removed review request for @cahamed
changed milestone to %14.9
removed review request for @vincywilson
enabled an automatic merge when the pipeline for 5c9e52a7 succeeds
mentioned in commit c49c4c8c
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label