Skip to content
Snippets Groups Projects

Exit registration verification

Merged Alex Buijs requested to merge exit-registration-verification into master
All threads resolved!

What does this MR do and why?

This adds an Exit link to the required verification page, when the require_verification_for_namespace_creation experiment is enabled, which allows the user to skip credit card verification and group + project creation during signup. It can be toggled through a feature flag.

Issue: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/559

Screenshots or screen recordings

Screen_Shot_2022-02-10_at_13.21.54

How to set up and validate locally

  1. Enable the combined_registration experiment
    Feature.enable(:combined_registration)
  2. Enable the require_verification_for_namespace_creation experiment
    Feature.enable(:require_verification_for_namespace_creation)
  3. Enable the exit_registration_verification feature flag
    Feature.enable(:exit_registration_verification)
  4. Visit the combined registration page: http://localhost:3000/users/sign_up/groups_projects/new

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Buijs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • :wave: @justin_ho, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Alex Buijs added 1 commit

    added 1 commit

    • 21689fb8 - Add exit link to required verification when onboarding

    Compare with previous version

  • Alex Buijs requested review from @blabuschagne

    requested review from @blabuschagne

  • Ryan Cobb approved this merge request

    approved this merge request

  • Ryan Cobb removed review request for @rcobb

    removed review request for @rcobb

  • Brandon Labuschagne
  • Brandon Labuschagne
  • Brandon Labuschagne removed review request for @blabuschagne

    removed review request for @blabuschagne

  • Alex Buijs added 1 commit

    added 1 commit

    • 95ea4682 - Add exit link to required verification when onboarding

    Compare with previous version

  • Alex Buijs requested review from @blabuschagne

    requested review from @blabuschagne

  • Alex Buijs requested review from @alexpooley

    requested review from @alexpooley

  • Brandon Labuschagne approved this merge request

    approved this merge request

  • Brandon Labuschagne removed review request for @blabuschagne

    removed review request for @blabuschagne

  • added UX label

  • requested review from @huzaifaiftikhar1

  • Huzaifa Iftikhar approved this merge request

    approved this merge request

  • Huzaifa Iftikhar removed review request for @huzaifaiftikhar1

    removed review request for @huzaifaiftikhar1

  • Alex Pooley
  • Alex Pooley requested review from @cahamed

    requested review from @cahamed

  • Alex Pooley approved this merge request

    approved this merge request

  • Alex Pooley requested review from @vincywilson and removed review request for @cahamed

    requested review from @vincywilson and removed review request for @cahamed

  • Alex Pooley changed milestone to %14.9

    changed milestone to %14.9

  • Alex Pooley removed review request for @vincywilson

    removed review request for @vincywilson

  • Alex Pooley resolved all threads

    resolved all threads

  • Alex Pooley enabled an automatic merge when the pipeline for 5c9e52a7 succeeds

    enabled an automatic merge when the pipeline for 5c9e52a7 succeeds

  • Careem Ahamed approved this merge request

    approved this merge request

  • merged

  • Alex Pooley mentioned in commit c49c4c8c

    mentioned in commit c49c4c8c

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading