Move findings deletion into a worker using pub-sub system for `Ci::JobArtifacts::DestroyBatchService`
What does this MR do and why?
This MR introduces event worker using pub-sub to execute security_findings
deletion for JobArtifacts::DestroyBatchService
to avoid cross database modification.
- Publish event on artifact deletion
- Worker for findings deletion so that we can delete them async
Related to #346236 (closed)
Merge request reports
Activity
changed milestone to %14.8
assigned to @subashis
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs ( @alexbuijs
) (UTC+1, 8 hours ahead of@subashis
)Mayra Cabrera ( @mayra-cabrera
) (UTC-6, 1 hour ahead of@subashis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
security_findings_delete_by_job_id
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit 903b1054
added typemaintenance label
mentioned in commit 8ec12f71
mentioned in commit 1ddbe392
mentioned in commit 15dd1c99
mentioned in commit 695eea10