Allow offline cloud license upload
What does this MR do and why?
Part of https://gitlab.com/gitlab-org/gitlab/-/issues/349611
Allow the upload of offline cloud licenses.
How to set up and validate locally
Since CustomersDot does not support all of the required workflows yet (at the time of writing this), I think the quickest way to test this is to purchase a new self-managed subscription and modify some code to create the license:
- Purchase a self-managed subscription.
- Add the following code after this line:
license.offline_cloud_licensing_enabled = offline_cloud_licensing_enabled?
- Go to your local CustomersDot's rails console and create a new license with the purchased subscription:
subscription = Customer.find(<CUSTOMER_ID>).find_subscription(<SUBSCRIPTION_NAME>) License.build_from_subscription(subscription: subscription)
- Upload the license key to your local GitLab instance.
- With the changes here, it should successfully work.
- Without the changes, an invalid license key error should show up.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
added backend devopsfulfillment groupprovision sectionfulfillment typefeature workflowin dev + 1 deleted label
assigned to @cwiesner
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alan (Maciej) Paruszewski ( @mparuszewski
) (UTC+1, same timezone as@cwiesner
)Thong Kuah ( @tkuah
) (UTC+13, 12 hours ahead of@cwiesner
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost Usermentioned in commit 4cc1df0f
Allure report
allure-report-publisher
generated test report for 98215f5e!review-qa-reliable:
📝 test report
review-qa-smoke:📝 test reportEdited by Ghost Usermentioned in commit 0a027c31
added 169 commits
-
4cc1df0f...a7f29713 - 168 commits from branch
master
- 0a027c31 - Allow offline cloud license upload
-
4cc1df0f...a7f29713 - 168 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in commit 6896166f
mentioned in commit f2b84bbc
added 436 commits
-
6896166f...3edf062f - 435 commits from branch
master
- f2b84bbc - Allow offline cloud license upload
-
6896166f...3edf062f - 435 commits from branch
mentioned in merge request !80382 (merged)