Skip to content

Add confirmation modal for merge button when pipeline has failed

Payton Burdette requested to merge 330851-improve-failed-merge-check-ux into master

What does this MR do and why?

  • Remove danger variant from merge button
  • Add confirmation modal for merge button when pipeline has failed

Screenshots or screen recordings

before after
Screen_Shot_2022-01-20_at_1.58.39_PM Screen_Shot_2022-01-20_at_2.08.18_PM

merge_button

How to set up and validate locally

  1. Setup simple CI project
  2. Ensure no merge checks are enabled in settings for project
  3. Create MR
  4. Cancel pipeline (to be in a failed state)
  5. Try to merge the code changes
  6. Ensure other merge methods work as expected

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #330851 (closed)

Edited by Payton Burdette

Merge request reports