ci: Remove the `rspec fast_spec_helper minimal` which is useless
What does this MR do and why?
I realized that this job is useless as bin/rspec spec/fast_spec_helper.rb
only makes sure the spec/fast_spec_helper.rb
file can load properly (this was originally introduced by !10544 (diffs, comment 156449264)).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @rymai
- A deleted user
added tooling (archive) label
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer ~"type::tooling" for CI, Danger Corinna Wiesner ( @cwiesner
) (UTC+1, same timezone as@rymai
)Albert Salim ( @alberts-gitlab
) (UTC+8, 7 hours ahead of@rymai
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@alberts-gitlab Could you please review? Thanks!
changed milestone to %14.8
added Engineering Productivity maintenancepipelines labels
requested review from @alberts-gitlab
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@alberts-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Albert
LGTM @rymai.
Actually I now wonder if
rspec fast_spec_helper
is still necessary. Looking at !10544 (merged), I'm not very sure what that job does. If it does not load, the rspec job would fail, no ?Edited by Albert
enabled an automatic merge when the pipeline for 5103ff3b succeeds
mentioned in issue #350700
mentioned in commit 9f4a28ae
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added typemaintenance label and removed tooling (archive) label
added releasedpublished label and removed releasedcandidate label