Rails 5: fix presence message validation for prometheus_alert
What does this MR do?
Rails 5 changed the required message validation from "can't be blank" to "must exist". See https://github.com/rails/rails/pull/18700 and https://github.com/thoughtbot/shoulda-matchers/issues/861. This check can be replaced by is_expected.to belong_to(:prometheus_alert).required
in version 4.x
of shoulda-matchers
but that version is unreleased yet.
Fixes ee/spec/models/prometheus_alert_event_spec.rb:16
. See https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/104963302.
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Edited by Rémy Coutable