Update security_reports_spec.rb
What does this MR do and why?
Describe in detail what your merge request does and why.
As per #348759 (closed)
!76939 (merged) added functionality such that container scanning results appear in the Dependency List. This MR updates the count in the test to include the mocked container scanning results.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
See #348759 (comment 783182715)
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Run CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://$INSTANCE/ ./qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added QA Quality devopssecure groupsecurity policies labels
FYI @nwestbury @ebanks fix for #348759 (closed)
added typemaintenance label
3 Warnings 266d6d7a: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Chloe Liu ( @chloeliu
) (UTC-8, 8 hours behind@willmeek
)Ramya Authappan ( @at.ramya
) (UTC+5.5, 5.5 hours ahead of@willmeek
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerThe
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/431792033 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/431806081 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/431806081 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/431834956 downstream.The
gitlab-qa
downstream pipeline passed. .The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/431918463 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/431932528 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/431932528 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/431963669 downstream.The
gitlab-qa
downstream pipeline passed. .
mentioned in issue #348759 (closed)
Allure report
allure-report-publisher
generated test report for 266d6d7a!review-qa-smoke:
test report
package-and-qa: test report
review-qa-all: test reportmentioned in issue gitlab-org/quality/pipeline-triage#112 (closed)
@acunskis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 972f7f50 succeeds
mentioned in commit ce897c1c
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
mentioned in issue gitlab-org/quality/pipeline-triage#113 (closed)
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in issue #297164 (closed)
added releasedpublished label and removed releasedcandidate label
mentioned in issue #419860 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#212 (closed)