Unify Security Configuration between EE and CE
What does this MR do and why?
The Security Configuration page needs to show different information depending on the tier the given project is in. Currently, the logic of that behavior is scattered in various places on the frontend and backend, which makes adding features or moving features to different tiers difficult and error-prone. read more in the issue description
In this MR we add a response for the CE version of SecurityConfigurationController
for json
request, so it returns configuration data. This change is behind the feature flag. It's needed until frontend is adjusted as well
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #339023 (closed)
Merge request reports
Activity
changed milestone to %14.6
added Category:Vulnerability Management Deliverable Enterprise Edition GitLab Core GitLab Free GitLab Premium GitLab Ultimate [deprecated] Accepting merge requests backend devopssecure groupcomposition analysis maintenancerefactor missed-deliverable missed:14.4 missed:14.5 priority2 quad-planningcomplete-action sectionsec typemaintenance workflowin dev + 1 deleted label
assigned to @brytannia
- A deleted user
added feature flag label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Vijay Hawoldar ( @vij
) (UTC+0, 2 hours behind@brytannia
)Luke Duncalfe ( @.luke
) (UTC+13, 11 hours ahead of@brytannia
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for c86b24c8!package-and-qa-ff-disabled:
test report
package-and-qa-ff-enabled: test reportremoved [deprecated] Accepting merge requests label
changed milestone to %14.7
added missed:14.6 label
added 1938 commits
-
e0da0711...75686c6d - 1935 commits from branch
master
- e2fc4b07 - wip
- c1f401c5 - Divide generation by EE/CE
- f56c3804 - Update only FOSS controller
Toggle commit list-
e0da0711...75686c6d - 1935 commits from branch
added pipeline:run-all-rspec pipeline:run-as-if-foss labels
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in issue #350177 (closed)
mentioned in issue #350179 (closed)
requested review from @egrieff
- Resolved by Etienne Baqué
@egrieff we are in close timezones, could you please review this MR?
The
package-and-qa-ff-enabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/446639971 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446672330 downstream.The
package-and-qa-ff-disabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/446639971 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446672392 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446672392 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/446703285 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446672330 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/446703311 downstream.The
gitlab-qa
downstream pipeline passed. .The
gitlab-qa
downstream pipeline passed. .
removed review request for @egrieff
@egrieff
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @ebaque
The
package-and-qa-ff-disabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/446733546 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446749798 downstream.The
package-and-qa-ff-enabled
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/446733546 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446750054 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446749798 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/446773364 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446750054 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/446775283 downstream.The
gitlab-qa
downstream pipeline passed. .The
gitlab-qa
downstream pipeline failed! .
- Resolved by Tetiana Chupryna
The
gitlab-qa
downstream pipeline failed! .
enabled an automatic merge when the pipeline for 3f6a20b3 succeeds
mentioned in commit 356491bd
added workflowstaging-canary label and removed workflowin dev label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !108854 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15281 (closed)