ci: Require a missing file in review-cleanup

What does this MR do and why?

This fixes a problem that I noticed in the latest scheduled pipelines: https://gitlab.com/gitlab-org/gitlab/-/jobs/1882193040

review-cleanup shows an error but continues when the namespace to clean up cannot be found:

$ delete_release
** Checking if review-fix-review-yclzl4 exists in the review-fix-review-yclzl4 namespace... **
Previous deployment for review-fix-review-yclzl4 NOT found.
$ delete_namespace
** Checking if review-fix-review-yclzl4 exists... **
Namespace review-fix-review-yclzl4 NOT found.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

assigned to @rymai

added tooling (archive) label

Pipeline Changes

This merge request contains changes to the pipeline configuration for the GitLab project.

Please consider the effect of the changes in this merge request on the following:

• Effects on different pipeline types
• Effects on non-canonical projects:
  • gitlab-foss
  • security
  • dev
  • personal forks
• Effects on pipeline performance

Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
~"type::tooling" for CI, Danger	George Koltsov (@georgekoltsov) (UTC+0, 1 hour behind @rymai)	Jen-Shin Lin (@godfat-gitlab) (UTC+8, 7 hours ahead of @rymai)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Allure report

allure-report-publisher generated test report for dfa4770e!

review-qa-smoke: test report

changed the description

changed milestone to %14.6

added Engineering Productivity maintenancepipelines labels

added 1 commit

• dfa4770e - ci: Require a missing file in review-cleanup

Compare with previous version

changed the description

@godfat-gitlab Could you please review? Thanks!

requested review from @godfat-gitlab

approved this merge request

@rymai Thank you, looks good to me!

@godfat-gitlab, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

enabled an automatic merge when the pipeline for 8da2b74f succeeds

Broken master: #347498 (closed)

resolved all threads

merged

mentioned in commit a470dd3e

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

added typemaintenance label and removed tooling (archive) label