Skip to content

Fix CI/CD settings available when CI/CD is off

Kev requested to merge KevSlashNull/gitlab:214334-Fix-CI-CD-settings-available-when-CI-CD-is-off into master

What does this MR do and why?

Currently, a project can disable the CI/CD setting and the left sidebar tab for CI/CD in settings is hidden, but users can still go to the page by using the url.

This MR prevents users from visiting the CI/CD settings when CI/CD is turned off via the project feature settings.

Screenshots or screen recordings

Before After
Before
Page is still accessible		 After
Page no longer accessible

How to set up and validate locally

  1. Go to a project
  2. Go to Settings > General
  3. Turn off CI/CD in the first section
  4. Go to /NAMESPACE/PROJECT/-/settings/ci_cd
  5. See that the page is a 404
  6. Turn on CI/CD again
  7. Go to /NAMESPACE/PROJECT/-/settings/ci_cd again
  8. See that the page renders the CI/CD settings.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #214334 (closed)

Edited by Austin Regnery

Merge request reports