Fix CI/CD settings available when CI/CD is off
requested to merge KevSlashNull/gitlab:214334-Fix-CI-CD-settings-available-when-CI-CD-is-off into master
What does this MR do and why?
Currently, a project can disable the CI/CD setting and the left sidebar tab for CI/CD in settings is hidden, but users can still go to the page by using the url.
This MR prevents users from visiting the CI/CD settings when CI/CD is turned off via the project feature settings.
Screenshots or screen recordings
Before | After |
---|---|
![]() Page is still accessible |
![]() Page no longer accessible |
How to set up and validate locally
- Go to a project
- Go to Settings > General
- Turn off CI/CD in the first section
- Go to
/NAMESPACE/PROJECT/-/settings/ci_cd
- See that the page is a 404
- Turn on CI/CD again
- Go to
/NAMESPACE/PROJECT/-/settings/ci_cd
again - See that the page renders the CI/CD settings.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #214334 (closed)
Edited by Austin Regnery