Update accessibility template v6.0.1
Ref: gitlab-org/ci-cd/accessibility#11 (closed)
What does this MR do and why?
This MR our accessibility ci template for pa11y
to its latest version v6.0.1. Here the full diff.
In this major version bump the new scanner will report more errors as it now using WCAG 2.1 rules.
To mitigate the impact on our users we added a changelog entry to users are aware the new scanner is now more strict and we also added a note to our documentation.
Why are we doing this?
As new software versions get released it's important to stay up to date so to protect ourself from security vulnerabilities and ~"technical debt" accumulation.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
added accessibility devopsverify grouppipeline security sectionops labels
assigned to @morefice
- A deleted user
added citemplates label
1 Warning Please add a merge request type to this merge request. 2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request adds or changes files that require a review from the CI/CD Templates maintainers. Documentation review
The following files require a review from a technical writer:
doc/user/project/merge_requests/accessibility_testing.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
- Prepare your MR for a CI/CD Template review according to the template development guide.
- Assign and
@
mention the CI/CD Template reviewer suggested by Reviewer Roulette.
The following files require a review from the CI/CD Templates maintainers:
lib/gitlab/ci/templates/Verify/Accessibility.gitlab-ci.yml
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer citemplates Sean Arnold ( @seanarnold
) (UTC+13, 12 hours ahead of@morefice
)Matija Čupić ( @matteeyah
) (UTC+1, same timezone as@morefice
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1058 commits
-
06c2b93e...2b5e3a6a - 1057 commits from branch
master
- ae0d5e31 - Update accessibility template v6.0.1
-
06c2b93e...2b5e3a6a - 1057 commits from branch
- A deleted user
added documentation label
added 1323 commits
-
bd93298d...3df3912b - 1322 commits from branch
master
- 1e750841 - Update accessibility template v6.0.1
-
bd93298d...3df3912b - 1322 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added Technical Writing label
- Resolved by Matija Čupić
@seanarnold could you review this MR please? @eread could you review this MR please?
requested review from @seanarnold and @eread
- Resolved by Max Orefice
added twdoing label
removed review request for @eread
requested review from @eread
requested review from @matteeyah and removed review request for @eread
@eread
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @seanarnold
added 1051 commits
-
6a0718ba...33f3763b - 1049 commits from branch
master
- 789fcff8 - Update accessibility template v6.0.1
- ddda9c7b - Apply code review feedback
-
6a0718ba...33f3763b - 1049 commits from branch
added typefeature label
added typemaintenance label and removed typefeature label
mentioned in commit f2739c1e
Thanks for your review
♂️added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
mentioned in issue gitlab-org/ci-cd/accessibility#11 (closed)
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added docsimprovement label
added Category:Code Testing and Coverage testingaccessibility labels