Make codeowners behavior before / after 13.10 clearer
What does this MR do?
Attempts to articulate the changes in Code Owners / MR approvals interactions that happened between 13.10 / 13.11.
Related issues
Related to #331548 (closed)
Author's checklist
-
Consider taking the GitLab Technical Writing Fundamentals course -
Follow the: -
Ensure that the product tier badge is added to topic's h1
. -
Request a review based on: - The documentation page's metadata.
- The associated Technical Writer.
If you are only adding documentation, do not add any of the following labels:
~"feature"
~"frontend"
~"backend"
~"bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Review checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review. -
Ensure a release milestone is set.
Merge request reports
Activity
changed milestone to %14.7
assigned to @aqualls
removed typebug label
removed SLOMissed label
removed missed:14.3 label
removed missed:14.4 label
removed regression label
removed regression:13.11 label
removed customer label
removed SLONear Miss label
removed [deprecated] Accepting merge requests label
removed severity2 label
removed priority2 label
changed milestone to %14.5
1 Warning Please add a merge request type to this merge request. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/project/merge_requests/approvals/settings.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Evan Read
Assigning over to @sean_carroll and @kchappell for review. Is this statement enough to get us some breathing room between now and when #331548 (closed) is fixed?
requested review from @sean_carroll and @kchappell