Skip to content

danger: Don't warn for missing labels while adding some

What does this MR do and why?

This changes the Danger rules that adds labels to only add the labels to an array, and let the main Dangerfile handle the actual API request to add the labels (with a single gitlab.api.update_merge_request instead of potentially 4 different ones before).

The main reason for this change is to prevent Danger from warning about a missing MR type label, while the label is actually added in the same job.

Screenshots or screen recordings

Screen_Shot_2021-10-25_at_16.18.26

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343748 (closed).

Edited by Rémy Coutable

Merge request reports