Skip to content

Draft: Add 'Failed' tab to list failed jobs and/or pipelines

Henryk Paluch requested to merge hpaluch/gitlab:hpaluch-tab-failed into master

What does this MR do and why?

This MR adds new Failed tab to both Pipelines and Jobs views. The rationale is that Administrator need to quickly know when something went wrong and what went wrong.

This feature is handy for Jobs lists, because there are no custom filters yet. It is also handy for Pipelines lists, but not strictly necessary (it is possible to define custom Pipeline filter with same results).

This MR has no exact Issue however there are exist similar Issues:

  • Issue #19679 - here creator requests list of failed jobs (which this MR does) however for Group view (which this MR does not - only for Admin Area -> Jobs and Project's Jobs).
  • Issue #22626 (closed) - her creator requests job filter in Admin area (this MR adds Failed job filter to Admin Area, but not generic filter as Issue creator requested).

Screenshots or screen recordings

Added Failed tab on Admin Area -> Jobs

admin-area-failed-jobs-web

Added Failed tab to "Project" -> Jobs

project-failed-jobs-web

Added Failed tab to "Project" -> Pipelines

project-failed-pipelines-web

How to set up and validate locally

Requirements:

  • have at least 1 failed pipeline
  • have at least 1 failed job

Both requirements are met by current GDK fixtures with gitlab commit: ad0085ce

  1. Go to Admin Area -> Jobs
  2. Verify that new tab Failed exists
  3. Click on tab Failed
  4. Verify that only jobs in failed status are shown
  5. Go to project with at least one failed Pipeline
  6. click on CI/CD -> Pipelines
  7. Verify that new tab Failed exists
  8. click on tab Failed
  9. Verify that only Pipelines in failed state are shown
  10. now click on CI/CD -> Jobs
  11. Verify that new tab Failed exists
  12. click on tab Failed
  13. Verify that only Jobs in failed state are shown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Henryk Paluch

Merge request reports