Skip to content

Clean-up secure jobs config

Philippe Lafoucrière requested to merge clean-up-secure-jobs into master

What does this MR do and why?

Describe in detail what your merge request does and why.

  • allow_failure: true is redefined for every job, but it's a the default already for all secure jobs in their respective templates. I couldn't find anything in the config that could set this to false by default, so I think we can safely get rid of it.
  • The gemnasium-maven-dependency_scanning is triggered on master, even though we don't have anything "java". The job fails silently.
  • The workaround for the execa vulnerability should be needed anymore, I don't see this vulnerability in https://gitlab.com/gitlab-org/gitlab/-/pipelines/387803884/?reportType=DEPENDENCY_SCANNING.

Some open questions too:

@rymai could you please take a look? thanks

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Philippe Lafoucrière

Merge request reports