Remove column ignore rules for migrated PKs
What does this MR do and why?
This MR removes column ignore rules for the following tables:
- ci_builds
- ci_builds_metadata
- ci_job_artifacts
- ci_sources_pipelines
- events
- push_event_payloads
- taggings
All columns were removed in 14.4.
We also remove IgnorableColumns
module for models that no more have columns ignored, and had rules removed with !71161 (merged).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.5
assigned to @krasio
mentioned in issue #338055 (closed)
mentioned in issue #338071 (closed)
mentioned in issue #338072 (closed)
mentioned in issue #338059 (closed)
mentioned in issue #338068 (closed)
mentioned in issue #338070 (closed)
mentioned in issue #338067 (closed)
- A deleted user
added backend label
2 Warnings Please add a merge request type to this merge request. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Pavel Shutsin ( @pshutsin
) (UTC+2, 11 hours behind@krasio
)Alper Akgun ( @a_akgun
) (UTC+3, 10 hours behind@krasio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
Allure report
allure-report-publisher
generated test report for 27c9a5e7!review-qa-smoke:
test reportSetting label groupdatabase based on
@krasio
's group.added groupdatabase label
added Engineering Allocation label
Setting label(s) Category:Database devopsenablement sectionenablement based on groupdatabase.
added Category:Database devopssystems sectioncore platform labels
added 1271 commits
-
ef4c1844...438c3b27 - 1269 commits from branch
master
- 3aa9b3d5 - Remove column ignore rules for migrated PKs
- 72d4e3b4 - Remove IgnorableColumns module for models that have no ignored columns
-
ef4c1844...438c3b27 - 1269 commits from branch
mentioned in merge request !72378 (merged)
- Resolved by Patrick Bair
@dfrazao-gitlab Can you please review this one?
requested review from @dfrazao-gitlab
requested review from @pbair and removed review request for @dfrazao-gitlab
@dfrazao-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added databaseapproved label
enabled an automatic merge when the pipeline for 292bf16c succeeds
added 416 commits
-
72d4e3b4...62ff6345 - 414 commits from branch
master
- d9708d6c - Remove column ignore rules for migrated PKs
- 27c9a5e7 - Remove IgnorableColumns module for models that have no ignored columns
-
72d4e3b4...62ff6345 - 414 commits from branch
- Resolved by Krasimir Angelov
Okay, we had some random failures yesterday and then conflicts earlier, but everything looks good now. Try again
enabled an automatic merge when the pipeline for 542d40aa succeeds
mentioned in commit 6f343281
added workflowverification label
added workflowstaging-canary label and removed workflowverification label
added workflowstaging label and removed workflowstaging-canary label