Remove column ignore rules for migrated PKs
What does this MR do and why?
This MR removes column ignore rules for PKs migrated to bigint
for the following tables:
ci_build_needs
ci_build_trace_chunks
ci_builds_runner_session
ci_stages
deployments
geo_job_artifact_deleted_events
All columns were removed in 14.3.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
assigned to @krasio
added groupdatabase typemaintenance labels
added typefeature label
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Albert Salim ( @alberts-gitlab
) (UTC+8, 5 hours behind@krasio
)Rémy Coutable ( @rymai
) (UTC+2, 11 hours behind@krasio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
mentioned in issue #338050 (closed)
mentioned in issue #338054 (closed)
mentioned in issue #338066 (closed)
mentioned in issue #338057 (closed)
mentioned in issue #338069 (closed)
mentioned in issue #338060 (closed)
- Resolved by Patrick Bair
@stomlinson Can you please review and pass to maintainer?
added workflowin review label
requested review from @stomlinson
added databasereviewed label
requested review from @pbair and removed review request for @stomlinson
@stomlinson
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added Engineering Allocation label
Setting label(s) Category:Database devopsenablement sectionenablement based on groupdatabase.
added Category:Database devopssystems sectioncore platform labels
added databaseapproved label and removed databasereviewed label
enabled an automatic merge when the pipeline for f7ab3ead succeeds
mentioned in commit 449214c6
mentioned in merge request !70946 (closed)
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in commit ef4c1844
mentioned in merge request !72161 (merged)
added releasedcandidate label
mentioned in commit 72d4e3b4
mentioned in commit 27c9a5e7
removed typefeature label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #331454
added devopsdata stores label and removed devopssystems label
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label
added pipeline:mr-approved label