Remove column ignore rules for migrated PKs
What does this MR do and why?
This MR removes column ignore rules for PKs migrated to bigint
for the following tables:
ci_build_needs
ci_build_trace_chunks
ci_builds_runner_session
ci_stages
deployments
geo_job_artifact_deleted_events
All columns were removed in 14.3.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
assigned to @krasio
added groupdatabase typemaintenance labels
added typefeature label
- A deleted user
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Albert Salim ( @alberts-gitlab
) (UTC+8, 5 hours behind@krasio
)Rémy Coutable ( @rymai
) (UTC+2, 11 hours behind@krasio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
- Resolved by Patrick Bair
mentioned in issue #338050 (closed)
mentioned in issue #338054 (closed)
mentioned in issue #338066 (closed)
mentioned in issue #338057 (closed)
mentioned in issue #338069 (closed)
mentioned in issue #338060 (closed)
- Resolved by Patrick Bair
@stomlinson Can you please review and pass to maintainer?