[VSA][FE] Add sorting and pagination to the project level stage table
What does this MR do and why?
Adds pagination and sorting support to the project VSA stage table. Currently the project vsa stage table has 2 columns (issue/merge request, and time) that can be used to sort the entries by.
The stage table displays 20 items on each page and will not display the pagination component if the stage contains less than 20 items in total.
Note: a separate issue will introduce deep linking for the filter parameters
Screenshots or screen recordings
project-vsa-sorting-pagination
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #335974 (closed)
Merge request reports
Activity
changed milestone to %14.4
assigned to @ekigbo
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/analytics/img/project_vsa_stage_table_v14_4.png
doc/user/analytics/value_stream_analytics.md
doc/user/group/value_stream_analytics/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
) (UTC+11, same timezone as@ekigbo
)Savas Vedova ( @svedova
) (UTC+2, 9 hours behind@ekigbo
)test Quality for spec/features/*
Sanad Liaquat ( @sliaquat
) (UTC+5, 6 hours behind@ekigbo
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f21f76b8 and 411aa84e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.23 MB 3.21 MB -21.37 KB -0.6 % mainChunk 1.89 MB 1.88 MB -1.37 KB -0.1 % Significant Reduction: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.dev_ops_report.show 4.19 MB 1.05 MB -3.13 MB -74.8 % pages.groups.analytics.devops_adoption 4.19 MB 1.05 MB -3.13 MB -74.9 %
Note: We do not have exact data for f21f76b8. So we have used data from: e9494c60.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 411aa84e!review-qa-smoke:
test reportadded workflowin dev label and removed workflowready for development label
added 59 commits
-
3cb5f48e...6bb96f42 - 57 commits from branch
master
- a9df74a2 - Add pagination to project vsa vuex store
- 793d8c44 - Apply pagination parameters to records request
-
3cb5f48e...6bb96f42 - 57 commits from branch
added typefeature label
added featureaddition label
added 161 commits
-
446ceca0...5988f878 - 158 commits from branch
master
- 7cdf01ab - Add pagination and sorting to project VSA staging table
- 5fddceab - Update vuex specs to include pagination
- 70584fcd - Update base_spec with pagination
Toggle commit list-
446ceca0...5988f878 - 158 commits from branch
- Resolved by Savas Vedova
added 151 commits
-
70584fcd...e905f975 - 145 commits from branch
master
- 5ca3a8e6 - Add pagination and sorting to project VSA staging table
- 3e659cbf - Update vuex specs to include pagination
- a9059afe - Update base_spec with pagination
- 48c53354 - Add feature specs for sorting the VSA stage table
- e026a203 - Added pagination specs and minor refactor
- eaf8a195 - Added docs for sorting and pagination
Toggle commit list-
70584fcd...e905f975 - 145 commits from branch
- A deleted user
added documentation label
- Resolved by Ezekiel Kigbo
added workflowin review label and removed workflowin dev label
- Resolved by Savas Vedova
- Resolved by Savas Vedova
- Resolved by Savas Vedova
Hi @fneill would you be free to review the documentation changes in this MR?
requested review from @fneill
- Resolved by Savas Vedova
requested review from @cngo
- Resolved by Sanad Liaquat
requested review from @sliaquat
mentioned in merge request gitlab-com/www-gitlab-com!91444 (merged)
- Resolved by Savas Vedova
- Resolved by Sanad Liaquat
removed review request for @sliaquat
- Resolved by Savas Vedova
- Resolved by Savas Vedova
added Technical Writing label
added docsfeature label
added tw-weight5 label
removed review request for @fneill
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 2 commits
removed review request for @sliaquat
removed review request for @fneill
mentioned in commit 7f6f70fc
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label