GithubImporter: Format diff note suggestions to the gitlab format
What does this MR do and why?
Github "suggestion" feature has a different markdown format, it uses:
```suggestion
SUGGESTION
```
While Gitlab has a range in the suggestion markdown, like:
```suggestion:-0+0
SUGGESTION
```
To convert the Github format to Gitlab, in the DiffNote
representation the range will be added. The range is calculated by the
difference of the start_line
and line
when the start_line is
present, which indicates a multi-line suggestion.
Related to: #340624 (closed)
This MR is just part of the solution, to make the imported diff notes with suggestions work we also have to change the importer to use the DiffNote
model instead of LegacyDiffNote
, which will be done in another MR.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Importer:GitHub devopsmanage + 1 deleted label
assigned to @kassio
mentioned in commit 54d97845
added 1 commit
- 54d97845 - GithubImporter: Format diff note suggestions to the gitlab format
- A deleted user
added databasereview pending label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Diogo Frazão ( @dfrazao-gitlab
) (UTC+2, 1 hour ahead of@kassio
)Igor Drozdov ( @igor.drozdov
) (UTC+3, 2 hours ahead of@kassio
)database Luis Mejia ( @lmejia2
) (UTC-6, 7 hours behind@kassio
)Mayra Cabrera ( @mayra-cabrera
) (UTC-5, 6 hours behind@kassio
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit a415e8ed
added 1 commit
- a415e8ed - GithubImporter: Format diff note suggestions to the gitlab format
added sectiondev label
added 1 commit
- 7f4eca5f - GithubImporter: Format diff note suggestions to the gitlab format
mentioned in commit 7f4eca5f
mentioned in commit 5c0ac149
added 1 commit
- 5c0ac149 - GithubImporter: Format diff note suggestions to the gitlab format
mentioned in commit 7f76d5f9
added 175 commits
-
abcfcd05...35967000 - 173 commits from branch
master
- 7f76d5f9 - GithubImporter: Format diff note suggestions to the gitlab format
- ad18174b - Update suggestion_formatter_spec.rb
-
abcfcd05...35967000 - 173 commits from branch
added 1 commit
- 05dc3d55 - GithubImporter: Format diff note suggestions to the gitlab format
mentioned in commit 05dc3d55
added 181 commits
-
05dc3d55...9b97b866 - 180 commits from branch
master
- f70e762e - GithubImporter: Format diff note suggestions to the gitlab format
-
05dc3d55...9b97b866 - 180 commits from branch
mentioned in commit f70e762e
mentioned in commit 17383e62
added 95 commits
-
abea8273...368a2a7c - 94 commits from branch
master
- 17383e62 - GithubImporter: Format diff note suggestions to the gitlab format
-
abea8273...368a2a7c - 94 commits from branch
mentioned in commit 8adf643a
added 1 commit
- 8adf643a - GithubImporter: Format diff note suggestions to the gitlab format
mentioned in commit 37133ddd
added 43 commits
-
8adf643a...f8b652b9 - 42 commits from branch
master
- 37133ddd - GithubImporter: Format diff note suggestions to the gitlab format
-
8adf643a...f8b652b9 - 42 commits from branch
added 138 commits
-
37133ddd...228e7ddd - 137 commits from branch
master
- 794abb5f - GithubImporter: Format diff note suggestions to the gitlab format
-
37133ddd...228e7ddd - 137 commits from branch
mentioned in commit 794abb5f
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Kassio Borges
@dstull, could you do the review of this one, please?
requested review from @dstull
mentioned in issue #340624 (closed)
- Resolved by Kassio Borges
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @dstull
added featureenhancement label
changed milestone to %14.4
added typefeature label
added 2 commits
assigned to @dstull