Skip to content
Snippets Groups Projects

Update Terraform.latest.gitlab-ci.yml template

Merged willian.eth requested to merge willianpaixao/gitlab:update-terraform-template into master
All threads resolved!

What does this MR do?

Update the Terraform.latest.gitlab-ci.yml template to reflect the new syntax in the terraform-images.

As suggested by @Alexand, the init stage is redundant.

Related issues

Check-list

Pre-merge

Consider the effect of the changes in this merge request on the following:

If new jobs are added:

This will help keep track of expected cost increases to the GitLab project average pipeline cost per merge request RPI

Post-merge

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I did some basic QA with this change and it works: https://gitlab.com/Alexand/terraform-test/-/pipelines/382096407

    I've tested with existing state and also deleting the state and restarting the pipeline.

  • requested review from @tigerwnz and @Alexand

  • willian.eth added 89 commits

    added 89 commits

    Compare with previous version

  • João Alexandre Cunha resolved all threads

    resolved all threads

  • willian.eth resolved all threads

    resolved all threads

  • Tiger Watson approved this merge request

    approved this merge request

  • Tiger Watson removed review request for @tigerwnz

    removed review request for @tigerwnz

  • willian.eth added 487 commits

    added 487 commits

    Compare with previous version

  • willian.eth added 12 commits

    added 12 commits

    Compare with previous version

    • Resolved by willian.eth

      @willianpaixao , the pipeline failure for this change unveiled that there is a bug in our Terraform stable template spec.

      The problem

      We have a feature that redirects stable template to their latest version if a feature flag is enabled. This happens here.

      Although, we have configured our specs to always run with all the feature flags enabled by default. This means that the specs for the stable CI templates will be loading the latest version instead, therefore testing the wrong one.

      The solution

      The solution is simple, we can stub the feature flag to return false in a before hook on the template stable spec. For Terraform, this would be adding the below to this block:

      stub_feature_flags(redirect_to_latest_template_terraform: false)

      For this MR this should be enough. Could you add this here, @willianpaixao ?


      FYI, @hfyngvason @shinya.maeda , we might want to have a quick look on other specs related to stable templates that might be being redirected to latest. I'll open a follow up issue for us to have a look at it.

  • willian.eth added 1 commit

    added 1 commit

    • 6ff3f96c - Update Terraform.latest.gitlab-ci.yml template

    Compare with previous version

  • willian.eth added 92 commits

    added 92 commits

    Compare with previous version

  • João Alexandre Cunha approved this merge request

    approved this merge request

  • requested review from @hfyngvason and @mwoolf

  • Max Woolf approved this merge request

    approved this merge request

  • Max Woolf removed review request for @mwoolf

    removed review request for @mwoolf

  • Hordur Freyr Yngvason
  • Hordur Freyr Yngvason
  • Thanks @willianpaixao :thumbsup:

    I just had one small suggestion, let me know what you think.

  • Hordur Freyr Yngvason approved this merge request

    approved this merge request

  • Hordur Freyr Yngvason requested review from @lauraX and removed review request for @Alexand and @hfyngvason

    requested review from @lauraX and removed review request for @Alexand and @hfyngvason

  • willian.eth added 1170 commits

    added 1170 commits

    Compare with previous version

  • Laura Montemayor approved this merge request

    approved this merge request

  • Hi @shinya.maeda - could you please merge this MR if you're ok with it? Thank you!

  • requested review from @shinya.maeda

  • Laura Montemayor removed review request for @lauraX

    removed review request for @lauraX

  • A deleted user added citemplates label

    added citemplates label

  • Shinya Maeda resolved all threads

    resolved all threads

  • Shinya Maeda enabled an automatic merge when the pipeline for b91106d9 succeeds

    enabled an automatic merge when the pipeline for b91106d9 succeeds

  • merged

  • Shinya Maeda mentioned in commit 60ae9dea

    mentioned in commit 60ae9dea

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 changed milestone to %14.5

    changed milestone to %14.5

  • willian.eth mentioned in commit a36e00c1

    mentioned in commit a36e00c1

  • Author Contributor

    @shinya.maeda would you mind adding the Hacktoberfest please?

  • added typemaintenance label and removed tooling (archive) label

  • mentioned in merge request !101756 (closed)

  • Please register or sign in to reply
    Loading