Skip to content

Remove PagesRemoveWorker

Vladimir Shushlin requested to merge 340641-remove-pagesremoveworker into master

What does this MR do and why?

In %14.4 we removed all calls to this worker, but we needed to leave this worker to clear any jobs that were in the queue.

Our guideline even suggest removing workers on major releases only: https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#removing-workers, but I think in this case it will be ok:

  • we've already cleared the queue on .com
  • on self-managed to have something in the queue, you would need to remove a pages project during upgrade from %14.2(or below) to %14.4(or above). And nothing bad will really happen if jobs will be in the queue.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #340641 (closed)

Edited by Vladimir Shushlin

Merge request reports