Skip to content
Snippets Groups Projects

Do not auto-retry unrecoverable `missing_dependency_failure` job failure

Merged Shinya Maeda requested to merge fix-subtransaction-retry-build into master
All threads resolved!

What does this MR do and why?

When a job is manual and is executed after a long time that dependencies are not longer valid, the job fails with missing_dependency_failure. In such cases, users have to re-create a pipeline or re-execute all of the upstream/depended jobs manually (i.e. not recoverable themselves). However, the system currently auto-retry such jobs, which results in a weird behavior that an unnecessary environment is re-spawned again.

This MR explicitly specify that missing_dependency_failure failure is not recoverable in the Auto-Retry service.

This also effectively mitigates the subtransaction issue.

Screenshots or screen recordings

Peek_2021-09-28_19-10

How to set up and validate locally

  1. Run a pipeline
  2. Erase an upstream job
  3. Play the downstream job
  4. Make sure the environment is not re-created

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shinya Maeda added 328 commits

    added 328 commits

    Compare with previous version

  • Shinya Maeda changed title from Fix subtransaction on Job Retry to {+Do not auto-retry unrecoverable missing_dependency_failure job failure+}

    changed title from Fix subtransaction on Job Retry to {+Do not auto-retry unrecoverable missing_dependency_failure job failure+}

  • A deleted user added documentation frontend labels

    added documentation frontend labels

  • Shinya Maeda changed the description

    changed the description

  • Shinya Maeda requested review from @stanhu and @krasio

    requested review from @stanhu and @krasio

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 0b00bb96 and d6870c2b

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.23 MB 3.23 MB - 0.0 %
    mainChunk 1.89 MB 1.89 MB - -0.0 %

    :tada: Significant Reduction: 12

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.profiles 281.81 KB 166.56 KB -115.25 KB -40.9 %
    pages.profiles.personal_access_tokens 341.81 KB 226.56 KB -115.25 KB -33.7 %
    pages.profiles.slacks 289.6 KB 174.35 KB -115.25 KB -39.8 %
    pages.profiles.two_factor_auths 416.34 KB 302.43 KB -113.91 KB -27.4 %
    pages.profiles.preferences.show 295.88 KB 182.61 KB -113.27 KB -38.3 %
    pages.profiles.show 1.1 MB 1021.15 KB -109.39 KB -9.7 %
    pages.profiles.accounts.show 350.23 KB 309.94 KB -40.3 KB -11.5 %
    pages.profiles.billings 330.48 KB 290.18 KB -40.3 KB -12.2 %
    pages.profiles.keys 287.48 KB 247.18 KB -40.3 KB -14.0 %
    pages.import.gitlab_projects.new 11.84 KB 10.57 KB -1.27 KB -10.8 %

    The table above is limited to 10 entries. Please look at the full report for more details


    Note: We do not have exact data for 0b00bb96. So we have used data from: da1009a2.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report for d6870c2b!

    review-qa-smoke: :pencil: test report

  • Cheryl Li changed milestone to %14.4

    changed milestone to %14.4

  • Stan Hu resolved all threads

    resolved all threads

  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu removed review request for @stanhu

    removed review request for @stanhu

  • :wave: @stanhu, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • A deleted user added documentation frontend labels

    added documentation frontend labels

    • Resolved by Shinya Maeda

      @shinya.maeda So this make jobs with missing_dependency_failure non-retriable? It makes sense, but I think we should update the commit message to explain what and why, because "Fix subtransaction on Job Retry" is a side-effect of this MR, right?

  • Krasimir Angelov removed review request for @krasio

    removed review request for @krasio

  • Shinya Maeda added 353 commits

    added 353 commits

    Compare with previous version

  • Shinya Maeda changed the description

    changed the description

  • Shinya Maeda resolved all threads

    resolved all threads

  • Shinya Maeda changed the description

    changed the description

  • Shinya Maeda marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Shinya Maeda added 1 commit

    added 1 commit

    • a1b8e1bf - Do not auto-retry unrecoverable job failure

    Compare with previous version

  • Stan Hu added 160 commits

    added 160 commits

    Compare with previous version

  • Shinya Maeda requested review from @vyaklushin and @tomquirk

    requested review from @vyaklushin and @tomquirk

  • Vasilii Iakliushin approved this merge request

    approved this merge request

  • Tom Quirk approved this merge request

    approved this merge request

  • Tom Quirk requested review from @psimyn and removed review request for @tomquirk

    requested review from @psimyn and removed review request for @tomquirk

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox resolved all threads

    resolved all threads

  • Author Maintainer

    Given that we have all approvals, I'll proceed the merge.

  • Shinya Maeda enabled an automatic merge when the pipeline for c6f7cd81 succeeds

    enabled an automatic merge when the pipeline for c6f7cd81 succeeds

  • merged

  • Shinya Maeda mentioned in commit ea0528bd

    mentioned in commit ea0528bd

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Shinya Maeda mentioned in merge request !72281 (merged)

    mentioned in merge request !72281 (merged)

  • Shinya Maeda mentioned in merge request !72970 (merged)

    mentioned in merge request !72970 (merged)

  • Shinya Maeda mentioned in merge request !73150 (merged)

    mentioned in merge request !73150 (merged)

  • Please register or sign in to reply
    Loading