Fix startup_css_changed to not check `ee` if FOSS_ONLY
What does this MR do and why?
This MR fixes the pipeline failure in !70000 (merged) which was caused by ee/
being removed for as-if-foss
therefore caught by an overly greedy git diff
check.
How to set up and validate locally
To test that this works in the happy path:
- Run
./scripts/frontend/startup_css/startup_css_changed.sh && echo "PASS"
. - The
PASS
message should show up.
To test that this would catch ee/
errors correctly:
- Make a random change to
ee/app/assets/stylesheets/startup/startup-signin.scss
. - Run
./scripts/frontend/startup_css/startup_css_changed.sh && echo "PASS"
. - The
PASS
should not show and a diff for how to fix the job should be printed. - Run
FOSS_ONLY=1 ./scripts/frontend/startup_css/startup_css_changed.sh && echo "PASS"
- The
PASS
should show up.
To test that this would catch CE errors correctly:
- Make a random change to
app/assets/stylesheets/startup/startup-signin.scss
. - Run
./scripts/frontend/startup_css/startup_css_changed.sh && echo "PASS"
. - The
PASS
should not show and a diff for how to fix the job should be printed. - Run
FOSS_ONLY=1 ./scripts/frontend/startup_css/startup_css_changed.sh && echo "PASS"
- The
PASS
should not show and a diff for how to fix the job should be printed.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #341245 (closed)
Edited by Paul Slaughter