`startup-css-check as-if-foss` runs with the `ee/` folder present
Is it expected that startup-css-check as-if-foss
runs with the ee/
folder present?
The only difference between startup-css-check
and startup-css-check as-if-foss
is the artifacts they depend on (compile-test-assets
, rspec frontend_fixture
, rspec-ee frontend_fixture
for the former; compile-test-assets as-if-foss
, rspec frontend_fixture as-if-foss
for the latter).
So, even though startup-css-check as-if-foss
extends .as-if-foss
, the extended job .frontend-test-base
doesn't use .default-before_script
so the ee/
folder is never removed. This can be seen in https://gitlab.com/gitlab-org/gitlab/-/jobs/1604157361.
I discovered this while working on !70000 (merged), where I fixed changed .frontend-test-base
to properly extends .default-before_script
so that ee/
is removed in the "as-if-foss" context, but now the job fails and suggest applying a diff to remove the ee/app/assets/stylesheets/startup/*
files, see https://gitlab.com/gitlab-org/gitlab/-/jobs/1600623268.
Now that I see it, I think it's expected that ee/
isn't removed from startup-css-check as-if-foss
to avoid the job failure and the wrong suggested diff (since we're in the "as-if-foss" context, the ee/
folder is checked in so it's normal that the diff suggest to remove all the EE startup CSS files). That being said, since the startup-css-check as-if-foss
extends .as-if-foss
, I'm still wondering if the current behavior is what was originally anticipated when introducing the job.