Skip to content

Remove custom getter methods for secondary emails

What does this MR do?

This MR removes custom getter methods for secondary emails. Instead of overriding commit_email and notification_email methods (let them read from database) it's adding methods like commit_email_or_default (read commit email value, or if nil, take the primary email value), and using them when the default is needed.

It's partly a follow up of !69234 (merged), for the broader context see https://gitlab.com/groups/gitlab-org/-/epics/6564.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Magdalena Frankiewicz

Merge request reports