Skip to content

Fix selected for User#commit_email input

Dan Jensen requested to merge djensen-fix-user-commit-email-input into master

What does this MR do?

This fixes the input for User#commit_email so the correct option is selected. Previously if no database value was set, a default value (User#email) was set as the selected option. We don't want to set a database value without user input, so this removes the default value.

This is a follow-up to !68591 (merged). That removed the first mechanism for setting an input value without any user action. This removes the second (and final) mechanism.

Note: This is similar to the recent change to User#notification_email, but more refactoring has been required for User#commit_email.

Does this MR meet the acceptance criteria?

Conformity

Related to https://gitlab.com/groups/gitlab-org/-/epics/6564

Edited by Dan Jensen

Merge request reports