Skip to content

Strip whitespace from saml group link name

Alejandro Guerrero requested to merge add-grouplink-whitespace-validation into master

What does this MR do?

This MR adds a method to strip any preceeding and succeeding whitespace from the saml_group_name parameter before it's saved on the saml_group_link.rb model.

Without this, whitespace that's entered by accident when creating a SAML Group Link will be included in the name, and due to #339797 (closed) the user will not be able to notice the whitespace on the GUI after it's saved, potentially causing groups not to match and difficult troubleshooting.

Closes #339797 (closed)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alejandro Guerrero

Merge request reports