Whitespace in SAML Group Links is not shown on the GUI
Summary
Whitespace in SAML Group Links (at the beginning or at the end of the group link) is not shown upon save.
The same whitespace can be seen from the backend by querying the Rails console directly, for example.
The fact that the GUI does not show the whitespace misleads troubleshooting of matching Group Links when whitespace is entered by accident on the Group Link name.
Steps to reproduce
- Enable SAML SSO for a GitLab Group (Premium + required).
- Go to "SAML Group Links" and configure a Group Link with whitespace either at the beginning or the end of the Group Link, example: " gitlab-test".
- When saving the Group Link, the resulting page does not show the whitespace.
- Querying the Rails Console will properly show the whitespace.
What is the current bug behavior?
Whitespace is not shown on the GUI.
What is the expected correct behavior?
Whitespace should be shown in the group link.
Output of checks
This bug happens on GitLab.com.
Possible fixes
Even though the problem is with the rendering of whitespace on the Group Links page, we should preemptively strip whitespace from the Group Links when they are saved.
Edited by Alejandro Guerrero