Skip to content

Fix editing predefined container policies

What does this MR do?

Fix editing predefined container policies

  • add __typename and kind to predefined container policy objects because that is how we determine the edit path for policies
  • update tests

How to setup and validate locally (strongly suggested)

  1. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  2. Follow the scan execution creation snippet to create some scan execution policies
  3. Turn on the :security_policies_orchestration_configuration feature flag
  4. Navigate to Security & Compliance => Policies
  5. Select one of the predefined policies to edit

Screenshots or Screencasts (strongly suggested)

Page Before After
Policies List - Predefined Policy Screen_Shot_2021-08-30_at_4.51.00_PM Screen_Shot_2021-08-30_at_4.49.59_PM
Edit Policies - Predefined Policy Screen_Shot_2021-08-30_at_4.51.05_PM Screen_Shot_2021-08-30_at_4.50.09_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #336947 (closed)

Edited by Alexander Turinske

Merge request reports