Eliminate `acts_as_taggable` gem for project topics
What does this MR do?
This MR is the second of two steps to resolve #335946 (closed). In the first step (see !67574 (merged)), the project topics data was migrated to two separate tables and it was ensured, that the project topics work correctly with old and new data during the background migration.
In this MR, the use of the acts_as_taggable
gem for project topics is finally eliminated. In addition, the temporary index tmp_index_taggings_on_id_where_taggable_type_project
is removed again.
Note: Since !67574 (merged) (with background migration) was merged in %14.3, this MR will apparently have to wait for %14.4.
/cc @bufferoverflow
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team