Skip to content
Snippets Groups Projects

Add documentation to Files API Rate Limits

All threads resolved!

What does this MR do?

Contributes to #335075

Roadmap

  1. Database migration MR: !68559 (merged)
  2. Throttling configuration form in Admin Area MR: !68560 (merged)
  3. Rack attack configuration MR: !68561 (merged)
  4. Documentation update <== This MR

Why

We want to have an option to rate limit Files API requests.

Current MR

  • Add documentation for Files API rate limit settings

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

  1. Enable feature flag:

    Feature.enable(:files_api_throttling)
  2. Go to Admin Area -> Network: http://localhost:3000/admin/application_settings/network

  3. Check that Files API Rate Limits section is appeared

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vasilii Iakliushin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vasilii Iakliushin changed the description

    changed the description

  • Nick Thomas mentioned in merge request !70310 (merged)

    mentioned in merge request !70310 (merged)

  • Amy Qualls added 1011 commits

    added 1011 commits

    • 9130fd19...7da78439 - 1008 commits from branch master
    • 3da4af85 - Add documentation to Files API Rate Limits
    • a014f3fb - Technical writing revisions: tone and style
    • 96733577 - Revise the instructions now that I have access

    Compare with previous version

  • Amy Qualls resolved all threads

    resolved all threads

  • Amy Qualls added 1 commit

    added 1 commit

    • 79f99fb1 - Revise the instructions now that I have access

    Compare with previous version

    • Resolved by Amy Qualls

      I have been the blocker on this MR, but now that I have access to the feature flag, I can see @vyaklushin's work in the UI. He and I are very very async because of timezones. I'd like to get this work merged, and then do a post-merge review on the docs changes. I'll use this thread to spin up an issue for that review.

      (I'm also going on PTO in a few days, and changes in a post-merge review can be handled by anyone on the Technical Writing team -- not just me!)

  • Amy Qualls resolved all threads

    resolved all threads

  • mentioned in issue #341304 (closed)

  • Amy Qualls changed milestone to %14.4

    changed milestone to %14.4

  • added tw-weight13 twfinished labels and removed tw-weight8 twdoing labels

  • Amy Qualls requested review from @sming-gitlab

    requested review from @sming-gitlab

  • Samantha Ming approved this merge request

    approved this merge request

  • :wave: @sming-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • mentioned in merge request gitlab-docs!2157 (merged)

  • Amy Qualls removed review request for @aqualls

    removed review request for @aqualls

  • Craig Norris added 1 commit

    added 1 commit

    Compare with previous version

  • Craig Norris resolved all threads

    resolved all threads

  • Craig Norris approved this merge request

    approved this merge request

  • @aqualls - Looks good. I made a minor change in one section to change an "in" to an "on" to match our style guidelines for interacting with the sidebar menu. Approved and merged.

  • merged

  • Craig Norris mentioned in commit f599cd82

    mentioned in commit f599cd82

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading