Skip to content

Keep admin settings sections expanded after submitting form

Mike Greiling requested to merge mg-keep-admin-settings-expanded into master

What does this MR do?

Part of gitlab-ce#35952, and an extension of gitlab-org/gitlab-ce!21040. This changes the behavior of all of the forms within collapsable sections in the administrator settings page such that when submitted, the resulting page will render with the form section expanded. The CE sections were covered in gitlab-org/gitlab-ce!21040 and this adds the EE-specific settings sections:

  • GitLab Geo settings
  • External authentication settings
  • Elasticsearch settings
  • Slack application settings
  • Custom project templates settings
  • Pseudonymizer data collection settings

Are there points in the code the reviewer needs to double check?

Submitting any form within the admin settings page should send you to the same page with the same section expanded. (before this, all sections would be collapsed after the form is submitted)

Why was this MR needed?

See issue description.

Screenshots (if relevant)

n/a

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Part of gitlab-ce#35952

Edited by Filipa Lacerda

Merge request reports