Skip to content
Snippets Groups Projects

Markdown Live preview for Source Editor

Merged Denys Mishunov requested to merge 280798-markdown-live-preview into master

What does this MR do?

Introduces the Live Preview functionality for the markdown extension of Source Editor. At the moment, the extension is only used when editing markdown files in a repository (single-file editor). Live Preview for WebIDE will be added as a separate MR.

Screenshots or Screencasts (strongly suggested)

Screenshot_2021-08-12_at_02.30.12

How to setup and validate locally (strongly suggested)

  1. Open a file in a project
  2. Click "Edit" (not WebIDE or Gitpod)
  3. You will get the regular instance of Source editor at this moment
  4. While focused in the editor do one of the following:
    • right-click and select "Preview Markdown", or
    • press SHIFT + Command + P (Shift + Ctrl + P on Windows) Screenshot_2021-08-12_at_02.26.25
  5. This will open the live preview panel to the right of the editor

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #280798 (closed)

Edited by Denys Mishunov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Kushal Pandya

      UX (non-blocker): It looks like the scrollbar placement is not aligned with part of the screen, refer the screencast below. I don't think this will be any blocker for the MR, but feel free to take a UX suggestions on it if you'd like to.

      markdown_preview_scrollbar

  • Denys Mishunov mentioned in commit 94a80607

    mentioned in commit 94a80607

  • Denys Mishunov added 434 commits

    added 434 commits

    Compare with previous version

  • Denys Mishunov mentioned in commit 2fffee26

    mentioned in commit 2fffee26

  • Denys Mishunov added 119 commits

    added 119 commits

    Compare with previous version

  • Denys Mishunov added 1 commit

    added 1 commit

    • b2853826 - Refactoring the markdown extension

    Compare with previous version

  • Denys Mishunov
  • Denys Mishunov
  • Denys Mishunov
  • Denys Mishunov
  • Denys Mishunov added 1 commit

    added 1 commit

    • 72cab205 - Refactoring the markdown extension

    Compare with previous version

  • Denys Mishunov added 1 commit

    added 1 commit

    • 866b7a96 - Refactoring the markdown extension

    Compare with previous version

  • requested review from @kushalpandya

  • Kushal Pandya
  • Kushal Pandya
  • Kushal Pandya removed review request for @kushalpandya

    removed review request for @kushalpandya

  • Denys Mishunov added 1 commit

    added 1 commit

    • 54febab7 - Switched to mocked axios adapter

    Compare with previous version

  • Denys Mishunov requested review from @kushalpandya and removed review request for @djadmin

    requested review from @kushalpandya and removed review request for @djadmin

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya approved this merge request

    approved this merge request

  • :wave: @kushalpandya, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Kushal Pandya enabled an automatic merge when the pipeline for 920d2da6 succeeds

    enabled an automatic merge when the pipeline for 920d2da6 succeeds

  • merged

  • Kushal Pandya mentioned in commit e7135c97

    mentioned in commit e7135c97

  • added workflowstaging label and removed workflowin dev label

  • added workflowcanary label and removed workflowstaging label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading